Add u-root and tmpfs to the bootstrap #970
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,22 @@ | ||
| #!/bin/sh | ||
|
|
||
| set -e | ||
|
|
||
| export GOBIN=$(pwd)/$(go env GOHOSTOS)_$(go env GOHOSTARCH)/bin | ||
| echo GOBIN is now $GOBIN | ||
|
|
||
| echo Building the build tool... | ||
| GO111MODULE=on go get ./util/src/harvey/cmd/... | ||
|
|
||
| echo Fetching u-root and building it... | ||
| GO111MODULE=on go get github.com/u-root/u-root | ||
|
|
||
| echo Fetch harvey-os.org commands and build them into $GOBIN | ||
| GO111MODULE=on go get harvey-os.org/cmd/... | ||
|
|
||
| echo FIXME -- once we get more architectures, this needs to be done in sys/src/cmds/build.json | ||
| echo Build tmpfs command into amd64 plan 9 bin | ||
| GO111MODULE=on GOOS=plan9 GOARCH=amd64 go build -o amd64/bin/tmpfs harvey-os.org/cmd/tmpfs | ||
|
|
||
| # this will make booting a VM easier | ||
| mkdir -p tmp | ||
|
|
@@ -15,12 +27,16 @@ export ARCH=amd64 | |
| # You also need to export your C compiler flavor (gcc, clang, gcc-7...) | ||
| export CC=gcc | ||
| # And build: | ||
| $GOBIN/build | ||
| # See \`build -h' for more information on the build tool. | ||
|
|
||
| To enable access to files, create a harvey and none user: | ||
| sudo useradd harvey | ||
| sudo useradd none | ||
|
|
||
| none is only required for drawterm/cpu access | ||
|
|
||
| Also: | ||
| export HARVEY=$(pwd) | ||
| add $GOBIN to your path | ||
|
There was a problem hiding this comment. if you add There was a problem hiding this comment. because I did not add GOBIN to the path, the script just recommends it? There was a problem hiding this comment. yea it's just a long cat-eof-style output comment - confused me at first as well when not looking closely 👀 starting here https://github.com/Harvey-OS/harvey/pull/970/files#diff-3af436e6760a0c5f1e3d16a3384853a8L12 There was a problem hiding this comment. yup. I was reviewing it using the mobile app missed the folded lines. my bad folks. I apologize There was a problem hiding this comment. those folded things can be hell. Thanks for the reviews everyone, I did set modules on, what else needs to change? |
||
| EOF | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be setting globals that we haven't declared. this is going to confuse the hell out of people when their binaries start showing up under
harvey/linux_amd64/bin, even after they stop playing with harvey.IMHO
HARVEYBINwould be better and wouldn't have as many side effects.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's set in this script, for this script and its children. That's not global, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GOBIN is for use by the go command.
I'm a bit lost on the problem of setting a variable in a script that's inherited by its children. This is not a global. export is for a process and its children. I don't see the issue here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that it might cause confusion at some point later on when extending the script @sevki? I.e., global from the script's perspective and all its child processes inheriting it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I screwed up. I was reviewing this on my phone and saw the entire change as a single block. I missed the folded lines.