Feature report #10
Open
Feature report #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmk-hsn
suggested changes
Jun 26, 2019
app/controllers/ad_controller.rb
Outdated
| def report | ||
| @report = Report.all | ||
| @ad = Ad.find(1) | ||
| p "afleihfjoiwahfoiawhgfoiahfoiaho" |
app/controllers/ad_controller.rb
Outdated
| @report = Report.all | ||
| @ad = Ad.find(1) | ||
| p "afleihfjoiwahfoiawhgfoiahfoiaho" | ||
| p @ad.class |
app/controllers/ad_controller.rb
Outdated
|
|
||
| def report_period | ||
| @ads = Ad.all | ||
| @Report = Report.where(date: ( params[:date_min])..( params[:date_max])) |
| @@ -13,7 +13,6 @@ | |||
| ActiveRecord::Schema.define(version: 2019_06_14_041856) do | |||
|
|
|||
| create_table "ads", force: :cascade do |t| | |||
| t.integer "advertiser_id", null: false | |||
There was a problem hiding this comment.
テーブル定義は消して大丈夫？
広告を作成する時に広告主IDを指定しないだけで、広告主に広告が紐づく構造は変わらないから消したらマズイ気が
app/controllers/ad_controller.rb
Outdated
| @@ -38,9 +38,21 @@ def destroy | |||
| redirect_to(ad_index_path) | |||
| end | |||
|
|
|||
| def report | |||
| @report = Report.all | |||
| @ad = Ad.find(1) | |||
There was a problem hiding this comment.
report.htmlの表示を司るアクションです。只今試行錯誤中です...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OJTのレポート開発(view,click)を行いました。
主な開発内容は以下の通りです。
Reportの結果を表示する開発に関しては午後より行なっていく予定です。
対応issue #8