Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Webpack@3 #341

Closed
wants to merge 0 commits into from
Closed

Update to Webpack@3 #341

wants to merge 0 commits into from

Conversation

mattlubner
Copy link
Contributor

@mattlubner mattlubner commented Dec 22, 2017

Changes

  1. Webpack, plugins, loaders, and configuration files updated to work with Webpack@3

Reverted Changes

The following changes are still needed, but I will submit them in a separate PR once I've isolated the issue with the "Should correctly give number of Posts" test intermittently failing.

  1. Removal of node --harmony-proxies flag from npm test script, for using Mern with a modern version of Node.js
  2. Minimum engine requirement bumped to >=6.5 in package.json
  3. Node versions tested in .travis.yml changed to LTS versions + latest (6.5, 8, 9)

Note that the removal of the --harmony-proxies flag is necessary as of Node v6.5, as the V8 engine no longer supports it.

@mattlubner
Copy link
Contributor Author

There seems to be a race condition in server/models/__tests__/post.spec.js that is intermittently causing the "Should correctly give number of Posts" test to fail.

@mattlubner
Copy link
Contributor Author

Hi @somus, are you the right person to ask about getting a PR reviewed & merged? 😀 I wasn't able to find any information on contributing to Mern (aside from the Code of Conduct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant