Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
glevco committed Oct 27, 2023
1 parent 88f031e commit 366e6ae
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion hathor/feature_activation/bit_signaling_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def __init__(

self._validate_support_intersection()

def generate_initial_logs(self) -> None:
def start(self) -> None:
"""
Log information related to bit signaling. Must be called after the storage is ready and migrations have
been applied.
Expand Down
2 changes: 1 addition & 1 deletion hathor/manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ def _initialize_components_new(self) -> None:
self.tx_storage.pre_init()
assert self.tx_storage.indexes is not None

self._bit_signaling_service.generate_initial_logs()
self._bit_signaling_service.start()

started_at = int(time.time())
last_started_at = self.tx_storage.get_last_started_at()
Expand Down
2 changes: 1 addition & 1 deletion tests/feature_activation/test_bit_signaling_service.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def get_bits_description_mock(block):
logger_mock = Mock()
service._log = logger_mock

service.generate_initial_logs()
service.start()

logger_mock.warn.assert_called_with(
'Considering the current best block, there are signaled features outside their signaling period. '
Expand Down

0 comments on commit 366e6ae

Please sign in to comment.