Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add first_block to the to_json_extended method of base transaction class #1003

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Apr 17, 2024

Motivation

Wallet Mobile needs the ability to show a nano contract transaction "status" in the token's transaction details modal, but this "status" requires to know if a nano contract transaction was already confirmed by a block of not, thus the first_block as a first citizen of a transaction.

Acceptance Criteria

  • It should add first_block to the to_json_extended to BaseTransaction for transactions.
  • It should update documentation in the following resources:
    • /dashboard_tx
    • /transaction
    • /thin_wallet/address_history
    • /thin_wallet/token_history

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@alexruzenhack alexruzenhack force-pushed the feat/tx-first-block branch 2 times, most recently from b0e3807 to f87d8bd Compare April 19, 2024 16:18
@alexruzenhack alexruzenhack enabled auto-merge (squash) April 22, 2024 17:56
@alexruzenhack alexruzenhack disabled auto-merge April 23, 2024 16:36
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (256739a) to head (cbd4c2d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1003      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.03%     
==========================================
  Files         298      298              
  Lines       22925    22928       +3     
  Branches     3463     3464       +1     
==========================================
- Hits        19470    19467       -3     
- Misses       2768     2771       +3     
- Partials      687      690       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit 5d3b757 into master Apr 26, 2024
12 checks passed
@jansegre jansegre deleted the feat/tx-first-block branch April 26, 2024 15:27
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants