Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix codecov coverage upload #1005

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore: fix codecov coverage upload #1005

merged 1 commit into from
Apr 25, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Apr 24, 2024

Motivation

Codecov's upload task on CI broke, it used to be unstable so we suspected that was the case but apparently it is now required to use a token.

Acceptance Criteria

  • Add a secret token to the repo's settings
  • Add CI config to expose the token to codecov's upload task

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (adc0191) to head (9a72f60).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1005      +/-   ##
==========================================
- Coverage   85.10%   84.88%   -0.23%     
==========================================
  Files         296      296              
  Lines       22909    22872      -37     
  Branches     3449     3460      +11     
==========================================
- Hits        19497    19414      -83     
- Misses       2732     2772      +40     
- Partials      680      686       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre marked this pull request as ready for review April 24, 2024 19:34
@jansegre jansegre requested a review from msbrogli as a code owner April 24, 2024 19:34
@jansegre jansegre requested a review from pedroferreira1 April 24, 2024 19:34
@jansegre jansegre self-assigned this Apr 25, 2024
@jansegre jansegre merged commit 85b02e7 into master Apr 25, 2024
12 checks passed
@jansegre jansegre deleted the chore/fix-codecov branch April 25, 2024 16:44
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants