Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing PeerId.source_file #1007

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: missing PeerId.source_file #1007

merged 1 commit into from
Apr 25, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Apr 25, 2024

Motivation

There is a bug in the p2p.reload_entrypoints_and_connections sysctl command, because the PeerId.source_file is not being set.

Acceptance Criteria

  • Set missing PeerId.source_file property.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label Apr 25, 2024
@glevco glevco self-assigned this Apr 25, 2024
@glevco glevco marked this pull request as ready for review April 25, 2024 17:25
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 84.87%. Comparing base (85b02e7) to head (bf98db4).

Files Patch % Lines
hathor/p2p/peer_id.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1007      +/-   ##
==========================================
+ Coverage   84.85%   84.87%   +0.02%     
==========================================
  Files         296      296              
  Lines       22872    22875       +3     
  Branches     3460     3460              
==========================================
+ Hits        19407    19415       +8     
+ Misses       2774     2771       -3     
+ Partials      691      689       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit d08ff49 into master Apr 25, 2024
12 checks passed
@glevco glevco deleted the fix/peer-id-source-file branch April 25, 2024 19:49
This was referenced May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants