refactor(verification): reorganize min_height verification #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
previously approved these changes
Apr 25, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1008 +/- ##
==========================================
- Coverage 84.97% 84.95% -0.02%
==========================================
Files 298 298
Lines 22932 22952 +20
Branches 3465 3466 +1
==========================================
+ Hits 19487 19500 +13
- Misses 2762 2766 +4
- Partials 683 686 +3 ☔ View full report in Codecov by Sentry. |
jansegre
previously approved these changes
Apr 26, 2024
glevco
force-pushed
the
fix/add-min-height-verification
branch
from
caa79d3 to
1a3f48d
Compare
jansegre
previously approved these changes
Apr 26, 2024
glevco
force-pushed
the
fix/add-min-height-verification
branch
from
1a3f48d to
6065308
Compare
jansegre
previously approved these changes
Apr 26, 2024
msbrogli
previously approved these changes
Apr 29, 2024
jansegre
approved these changes
Apr 30, 2024
msbrogli
approved these changes
Apr 30, 2024
glevco
force-pushed
the
fix/add-min-height-verification
branch
from
5dc99fa to
cbf10a7
Compare
This was referenced May 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reorganize the
min_heightverification.Acceptance Criteria
min_heightverification.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged