Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): update default Python version used on docker images #1010

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

jansegre
Copy link
Member

Motivation

The default has been 3.10 for a while now and it's the lowest supported version, meanwhile 3.11 has some useful performance improvements.

Acceptance Criteria

  • Change the default Python version used on Docker images from 3.10 to 3.11

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Apr 26, 2024
@jansegre jansegre requested a review from msbrogli as a code owner April 26, 2024 22:14
@jansegre jansegre requested a review from glevco April 26, 2024 22:14
glevco
glevco previously approved these changes Apr 27, 2024
@jansegre jansegre force-pushed the chore/update-default-python branch from e4b8a11 to 0df2ee4 Compare May 3, 2024 14:30
@jansegre jansegre force-pushed the chore/update-default-python branch from 0df2ee4 to be58fec Compare May 3, 2024 15:27
@jansegre jansegre force-pushed the chore/update-default-python branch 2 times, most recently from da18de6 to c68dade Compare June 11, 2024 16:36
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.86%. Comparing base (7f03142) to head (25a8abd).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1010   +/-   ##
=======================================
  Coverage   84.85%   84.86%           
=======================================
  Files         315      315           
  Lines       24071    24071           
  Branches     3647     3647           
=======================================
+ Hits        20425    20427    +2     
+ Misses       2930     2929    -1     
+ Partials      716      715    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the chore/update-default-python branch from c68dade to d2b5443 Compare August 15, 2024 13:21
Copy link

github-actions bot commented Aug 15, 2024

🐰Bencher

ReportTue, August 20, 2024 at 21:19:32 UTC
Projecthathor-core
Branchchore/update-default-python
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,436,728,921.12 (-1.91%)82,731,756,995.42 (81.56%)124,097,635,493.13 (81.74%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

msbrogli
msbrogli previously approved these changes Aug 20, 2024
extras/github/test_docker.py Outdated Show resolved Hide resolved
glevco
glevco previously approved these changes Aug 20, 2024
@jansegre jansegre force-pushed the chore/update-default-python branch from d2b5443 to 158cf50 Compare August 20, 2024 21:11
@jansegre jansegre dismissed stale reviews from glevco and msbrogli via 25a8abd August 20, 2024 21:13
@jansegre jansegre force-pushed the chore/update-default-python branch from 158cf50 to 25a8abd Compare August 20, 2024 21:13
@jansegre jansegre merged commit 411fb65 into master Aug 20, 2024
13 checks passed
@jansegre jansegre deleted the chore/update-default-python branch August 20, 2024 23:03
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants