Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: catch update_reward_lock_metadata exceptions #1029

Merged
merged 1 commit into from
May 8, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 8, 2024

Motivation

Correctly handle exceptions raised by update_reward_lock_metadata().

Acceptance Criteria

  • Move update_reward_lock_metadata() call to inside the validate_full() try block.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this May 8, 2024
@glevco glevco added the bug Something isn't working label May 8, 2024
@glevco glevco marked this pull request as ready for review May 8, 2024 18:30
@glevco glevco requested review from jansegre and msbrogli as code owners May 8, 2024 18:30
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (007eb6e) to head (adedf91).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.02%     
==========================================
  Files         298      297       -1     
  Lines       22962    22910      -52     
  Branches     3470     3464       -6     
==========================================
- Hits        19500    19452      -48     
  Misses       2773     2773              
+ Partials      689      685       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the fix/update-metadata-exception branch from 880c31d to adedf91 Compare May 8, 2024 19:03
@glevco glevco merged commit e947404 into master May 8, 2024
12 checks passed
@glevco glevco deleted the fix/update-metadata-exception branch May 8, 2024 19:58
This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants