Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up feature activation logs #1035

Merged
merged 1 commit into from
May 28, 2024
Merged

chore: clean up feature activation logs #1035

merged 1 commit into from
May 28, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 10, 2024

Motivation

Now that the Feature Activation Phased Testing has ended, we can remove some extra logs. Feature states are now logged together with the existing new block log. There's a small performance gain for removing the overhead of doubling logs.

Acceptance Criteria

  • Remove feature activation specific logging methods and move logging of feature states to _log_new_object().

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this May 10, 2024
@glevco glevco marked this pull request as ready for review May 10, 2024 16:56
@glevco glevco requested review from jansegre and msbrogli as code owners May 10, 2024 16:56
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.87%. Comparing base (97cb18e) to head (01bd409).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   84.88%   84.87%   -0.01%     
==========================================
  Files         297      297              
  Lines       22917    22906      -11     
  Branches     3466     3463       -3     
==========================================
- Hits        19453    19442      -11     
- Misses       2776     2777       +1     
+ Partials      688      687       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco force-pushed the chore/clean-up-logs branch from 77236f9 to 2e51255 Compare May 13, 2024 13:47
@glevco glevco force-pushed the chore/clean-up-logs branch from 2e51255 to 01bd409 Compare May 28, 2024 17:57
@glevco glevco merged commit 47831ae into master May 28, 2024
12 checks passed
@glevco glevco deleted the chore/clean-up-logs branch May 28, 2024 19:50
@jansegre jansegre mentioned this pull request Jun 3, 2024
2 tasks
@jansegre jansegre mentioned this pull request Jul 25, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants