Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): fix initialization on existing event storage #1038

Merged
merged 1 commit into from
May 21, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 17, 2024

Motivation

In v0.60.0 the signal_bits field was added to event's TxData, but that breaks when initializing with an existing event storage. That happened when trying to update the wallet service node.

Acceptance Criteria

  • Make event's TxData.signal_bits nullable.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the bug Something isn't working label May 17, 2024
@glevco glevco self-assigned this May 17, 2024
@glevco glevco marked this pull request as ready for review May 17, 2024 19:42
@glevco glevco requested review from jansegre and msbrogli as code owners May 17, 2024 19:42
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (ae56108) to head (d0875e9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1038      +/-   ##
==========================================
+ Coverage   84.87%   84.92%   +0.04%     
==========================================
  Files         297      297              
  Lines       22910    22910              
  Branches     3464     3464              
==========================================
+ Hits        19446    19457      +11     
+ Misses       2775     2768       -7     
+ Partials      689      685       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco merged commit 5122b9f into master May 21, 2024
15 of 16 checks passed
@glevco glevco deleted the fix/event-storage-initialization branch May 21, 2024 16:33
This was referenced May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants