-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(log): correctly handle errors when logging events #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
commented
May 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1040 +/- ##
==========================================
+ Coverage 84.94% 84.96% +0.02%
==========================================
Files 297 297
Lines 22906 22906
Branches 3463 3463
==========================================
+ Hits 19457 19462 +5
+ Misses 2765 2762 -3
+ Partials 684 682 -2 ☔ View full report in Codecov by Sentry. |
1 task
jansegre
previously approved these changes
May 23, 2024
glevco
force-pushed
the
fix/logging-errors
branch
from
May 28, 2024 17:58
ca4c8cf
to
bb0f1b2
Compare
jansegre
reviewed
May 28, 2024
glevco
force-pushed
the
fix/logging-errors
branch
from
May 28, 2024 19:01
9147964
to
5bfc088
Compare
jansegre
approved these changes
May 28, 2024
msbrogli
approved these changes
May 28, 2024
glevco
force-pushed
the
fix/logging-errors
branch
from
May 28, 2024 19:51
5bfc088
to
973afe6
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR contains 2 separate but related fixes that will improve our on-call overhead. They would cause some errors to be logged in multiple unstructured lines, generating several unnecessary alerts.
The first problem was that a bug in string formatting would generate an exception during log event processing, triggering the "error when logging event" path. The second problem was with the logging of this error itself, that was using print statements, and therefore generating the multiple unstructured lines.
This finally resolves https://github.com/HathorNetwork/on-call-incidents/issues/153.
Acceptance Criteria
KeyError
to be raised during logging.print()
statements when errors occur during logging.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged