Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resources): regression in address history endpoint #1042

Merged
merged 1 commit into from
May 28, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented May 28, 2024

Motivation

After the release o v0.60.0 a bug was reported in the address-history API. The bug was introduced after the optimizations in #978, reverting the PR makes the bug disappear.

Acceptance Criteria

  • Restore the correct behavior without undoing the optimizations
  • Add a test that reproduces the issue

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.83%. Comparing base (75605be) to head (749dfc1).

Files Patch % Lines
...or/wallet/resources/thin_wallet/address_history.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
- Coverage   84.89%   84.83%   -0.06%     
==========================================
  Files         297      297              
  Lines       22910    22914       +4     
  Branches     3464     3465       +1     
==========================================
- Hits        19449    19439      -10     
- Misses       2775     2783       +8     
- Partials      686      692       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msbrogli
msbrogli previously approved these changes May 28, 2024
pedroferreira1
pedroferreira1 previously approved these changes May 28, 2024
@jansegre jansegre dismissed stale reviews from pedroferreira1 and msbrogli via 749dfc1 May 28, 2024 16:40
@jansegre jansegre force-pushed the fix/address-history-regression branch from 43eaefb to 749dfc1 Compare May 28, 2024 16:40
@jansegre jansegre force-pushed the fix/address-history-regression branch from 749dfc1 to 97cb18e Compare May 28, 2024 17:42
@jansegre jansegre merged commit d13d5af into master May 28, 2024
11 checks passed
@jansegre jansegre deleted the fix/address-history-regression branch May 28, 2024 17:43
This was referenced May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants