-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): Add include_transactions parameter to the BlockAtHeightResource #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
reviewed
Jun 3, 2024
obiyankenobi
reviewed
Jun 3, 2024
msbrogli
force-pushed
the
feat/block_at_height-include-txs
branch
2 times, most recently
from
June 3, 2024 15:22
92dfc3a
to
e6eb0ec
Compare
jansegre
previously approved these changes
Jun 3, 2024
msbrogli
force-pushed
the
feat/block_at_height-include-txs
branch
from
June 3, 2024 15:30
e6eb0ec
to
057950d
Compare
msbrogli
force-pushed
the
feat/block_at_height-include-txs
branch
from
June 3, 2024 15:47
057950d
to
871b1f0
Compare
msbrogli
force-pushed
the
feat/block_at_height-include-txs
branch
from
June 3, 2024 16:20
871b1f0
to
8e9bfbc
Compare
obiyankenobi
approved these changes
Jun 3, 2024
pedroferreira1
approved these changes
Jun 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 84.97% 84.93% -0.04%
==========================================
Files 297 297
Lines 22917 22927 +10
Branches 3466 3470 +4
==========================================
Hits 19473 19473
- Misses 2763 2768 +5
- Partials 681 686 +5 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Jun 3, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some use cases can benefit from getting the list of transactions confirmed by a block, facilitating internal tasks and reducing the number of API calls.
Acceptance Criteria
include_transactions: str | None
toBlockAtHeightResource.render_GET
.include_transactions == "txid"
, the response will have a new keytx_ids: list[str]
with a list of tx ids in hex format.include_transactions == "full"
, the response will have a new keytransactions: list[dict]
with a list of tx details got fromtx.to_json_extended()
.QueryParams
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged