fix: improve stratum logs #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
fix/improve-stratum-logs
branch
from
fd2712c to
b19809e
Compare
jansegre
reviewed
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1049 +/- ##
==========================================
- Coverage 84.90% 84.88% -0.03%
==========================================
Files 300 300
Lines 22943 22944 +1
Branches 3470 3471 +1
==========================================
- Hits 19479 19475 -4
- Misses 2775 2779 +4
- Partials 689 690 +1 ☔ View full report in Codecov by Sentry. |
jansegre
approved these changes
Jun 4, 2024
msbrogli
approved these changes
Jun 10, 2024
glevco
force-pushed
the
fix/improve-stratum-logs
branch
from
1f595d8 to
493586b
Compare
glevco
force-pushed
the
fix/improve-stratum-logs
branch
from
493586b to
5d7ba93
Compare
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're receiving some calls to the stratum API with wrong arguments, but current code doesn't allow us to investigate it. This PRs adds logs that will help debugging this. See https://github.com/HathorNetwork/on-call-incidents/issues/176.
Acceptance Criteria
paramsto adict.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged