Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(p2p): split hathor.p2p.peer_discovery into separate modules #1055

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jun 6, 2024

Motivation

The hathor.p2p.peer_discovery module aggregates the abstraction and implementations, it could be split to make future implementations cleaner to review.

Acceptance Criteria

  • Split hathor.p2p.peer_discovery into the following submodules: peer_discovery (abstraction), dns (DNS implementation), bootstrap (bootstrap implementation), expose everything the same way they were being exposed before.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested review from msbrogli and glevco June 6, 2024 14:40
@jansegre jansegre self-assigned this Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.99%. Comparing base (40a25dc) to head (8aafd01).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1055      +/-   ##
==========================================
+ Coverage   84.92%   84.99%   +0.07%     
==========================================
  Files         297      300       +3     
  Lines       22932    22943      +11     
  Branches     3470     3470              
==========================================
+ Hits        19475    19501      +26     
+ Misses       2770     2760      -10     
+ Partials      687      682       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit b20be70 into master Jun 6, 2024
12 checks passed
@jansegre jansegre deleted the refactor/p2p-discovery-modules branch June 6, 2024 16:04
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants