refactor(p2p): split hathor.p2p.peer_discovery into separate modules #1055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
hathor.p2p.peer_discovery
module aggregates the abstraction and implementations, it could be split to make future implementations cleaner to review.Acceptance Criteria
hathor.p2p.peer_discovery
into the following submodules:peer_discovery
(abstraction),dns
(DNS implementation),bootstrap
(bootstrap implementation), expose everything the same way they were being exposed before.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged