feat(side-dag): update APIs #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
feat/side-dag/apis
branch
from
d5add1e to
fcab293
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
- Coverage 85.08% 85.07% -0.01%
==========================================
Files 309 309
Lines 23396 23421 +25
Branches 3529 3534 +5
==========================================
+ Hits 19906 19926 +20
- Misses 2790 2797 +7
+ Partials 700 698 -2 ☔ View full report in Codecov by Sentry. |
glevco
changed the base branch from
tests/side-dag
to
refactor/misc-improvements
glevco
force-pushed
the
feat/side-dag/apis
branch
2 times, most recently
from
d93bc97 to
a4f3e1b
Compare
1 task
glevco
force-pushed
the
refactor/misc-improvements
branch
from
4c360b0 to
d7b0002
Compare
glevco
force-pushed
the
feat/side-dag/apis
branch
from
6d715f6 to
e2b69ec
Compare
jansegre
reviewed
Jul 5, 2024
msbrogli
requested changes
Jul 5, 2024
1 task
jansegre
approved these changes
Jul 8, 2024
glevco
force-pushed
the
refactor/misc-improvements
branch
from
d7b0002 to
14c8403
Compare
glevco
force-pushed
the
feat/side-dag/apis
branch
from
e2b69ec to
1579702
Compare
msbrogli
previously approved these changes
Jul 12, 2024
jansegre
previously approved these changes
Jul 12, 2024
glevco
force-pushed
the
refactor/misc-improvements
branch
3 times, most recently
from
eead7ac to
6a9693d
Compare
glevco
changed the base branch from
refactor/misc-improvements
to
tests/side-dag
glevco
force-pushed
the
feat/side-dag/apis
branch
2 times, most recently
from
6cafbdf to
bbea340
Compare
glevco
force-pushed
the
tests/side-dag
branch
2 times, most recently
from
c1b770d to
59295e8
Compare
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
feat/side-dag/apis
branch
from
bbea340 to
fc3a749
Compare
jansegre
approved these changes
Jul 18, 2024
msbrogli
approved these changes
Jul 18, 2024
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update API response models to include side-dag and Proof-of-Authority related data.
Acceptance Criteria
NATIVE_TOKEN_NAMEandNATIVE_TOKEN_SYMBOLtoHathorSettingsand to the/v1a/versionAPI.DECIMAL_PLACESand genesis hashes to the/v1a/versionAPI.PoaBlock.to_json()to include PoA fields.poa.get_signer_index_and_public_key()and updatePoaBlockVerifierto use it.PoaBlocktimestamp verification.create_parser(), adding support for environment variables.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged