Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(side-dag): add signers validation on peer hello #1078

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jul 1, 2024

Depends on #1075

Motivation

This PR adds a validation of PoA signers list when peers connect.

Acceptance Criteria

  • Add consensus algorithm validation on peer hello.
  • Change Builder so it requires settings to be set.
  • Update P2P related code to use injected settings.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco self-assigned this Jul 1, 2024
@glevco glevco marked this pull request as ready for review July 1, 2024 17:35
@glevco glevco requested review from jansegre and msbrogli as code owners July 1, 2024 17:35
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 93.44262% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (0ded56d) to head (75c5dba).
Report is 2 commits behind head on master.

Files Patch % Lines
hathor/p2p/states/peer_id.py 66.66% 1 Missing and 1 partial ⚠️
hathor/builder/builder.py 0.00% 1 Missing ⚠️
hathor/consensus/consensus_settings.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1078      +/-   ##
==========================================
+ Coverage   84.93%   85.09%   +0.16%     
==========================================
  Files         310      310              
  Lines       23524    23558      +34     
  Branches     3554     3561       +7     
==========================================
+ Hits        19979    20047      +68     
+ Misses       2839     2805      -34     
  Partials      706      706              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jansegre
jansegre previously approved these changes Jul 5, 2024
@glevco glevco force-pushed the feat/side-dag/add-signers branch from fe2945b to 4dc3e46 Compare July 5, 2024 18:32
@glevco glevco force-pushed the feat/side-dag/signers-validation branch from 54e6fa5 to 0abf019 Compare July 5, 2024 18:38
hathor/consensus/consensus_settings.py Show resolved Hide resolved
hathor/consensus/consensus_settings.py Outdated Show resolved Hide resolved
@glevco glevco force-pushed the feat/side-dag/add-signers branch from 4dc3e46 to 27f38be Compare July 8, 2024 21:26
@glevco glevco force-pushed the feat/side-dag/signers-validation branch from 0abf019 to 6868838 Compare July 8, 2024 21:26
msbrogli
msbrogli previously approved these changes Jul 12, 2024
@glevco glevco force-pushed the feat/side-dag/add-signers branch from ad736ff to 12a05bd Compare July 18, 2024 18:08
@glevco glevco force-pushed the feat/side-dag/signers-validation branch from b58b125 to 59a3dd9 Compare July 18, 2024 18:10
@glevco glevco force-pushed the feat/side-dag/add-signers branch 2 times, most recently from 26a1816 to 6bb8a4f Compare July 22, 2024 17:09
Base automatically changed from feat/side-dag/add-signers to master July 22, 2024 18:52
@glevco glevco dismissed stale reviews from msbrogli and jansegre July 22, 2024 18:52

The base branch was changed.

@glevco glevco force-pushed the feat/side-dag/signers-validation branch from 59a3dd9 to 244bb92 Compare July 22, 2024 19:16
msbrogli
msbrogli previously approved these changes Jul 22, 2024
@glevco glevco force-pushed the feat/side-dag/signers-validation branch from 244bb92 to be45ae2 Compare July 22, 2024 19:28
@glevco glevco force-pushed the feat/side-dag/signers-validation branch from be45ae2 to 75c5dba Compare July 22, 2024 19:46
@glevco glevco merged commit 53fa539 into master Jul 22, 2024
12 checks passed
@glevco glevco deleted the feat/side-dag/signers-validation branch July 22, 2024 21:04
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants