Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(storage): change storages to use injected settings #1081

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Jul 8, 2024

Motivation

Continue improving settings management by removing calls to global settings.

Acceptance Criteria

  • Update storage classes to use injected settings instead of the global one.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@glevco glevco added the refactor label Jul 8, 2024
@glevco glevco self-assigned this Jul 8, 2024
@glevco glevco force-pushed the refactor/storage-injected-settings branch from 22cc07e to 872fe5f Compare July 9, 2024 15:13
@glevco glevco force-pushed the refactor/storage-injected-settings branch from 872fe5f to 845e9c9 Compare July 9, 2024 15:52
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (f95d189) to head (845e9c9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   84.90%   84.93%   +0.02%     
==========================================
  Files         307      307              
  Lines       23173    23177       +4     
  Branches     3503     3503              
==========================================
+ Hits        19676    19685       +9     
+ Misses       2794     2791       -3     
+ Partials      703      701       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glevco glevco marked this pull request as ready for review July 9, 2024 16:27
@glevco glevco requested review from jansegre and msbrogli as code owners July 9, 2024 16:27
@jansegre jansegre merged commit 7c7c261 into master Jul 9, 2024
11 checks passed
@jansegre jansegre deleted the refactor/storage-injected-settings branch July 9, 2024 20:26
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants