fix(p2p): regression after entrypoint refactor #1088
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#1086 introduced a regression as can be seen in the failed docker build, during the image test
Acceptance Criteria
Entrypoint.peer_id
should default toNone
(mypy didn't catch this)defer.gatherResults
had to be chained before passing it toset
ProtocolMessages.PEERS
data was being constructed withEntrypoint
objects, which can't be used injson.dumps
, it needed to be converted tostr
PeerId.__str__
so it usesstr(entrypoint)
instead ofrepr(entrypoint)
to keep it less verboseChecklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged