fix(p2p): status regression after entrypoint refactor #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1089 +/- ##
==========================================
+ Coverage 84.79% 84.86% +0.07%
==========================================
Files 314 314
Lines 23900 23901 +1
Branches 3612 3609 -3
==========================================
+ Hits 20265 20283 +18
+ Misses 2917 2906 -11
+ Partials 718 712 -6 ☔ View full report in Codecov by Sentry. |
glevco
previously approved these changes
Jul 24, 2024
jansegre
force-pushed
the
fix/p2p-status-regression
branch
from
e200f7b to
d0c2b6b
Compare
jansegre
force-pushed
the
fix/p2p-status-regression
branch
from
d0c2b6b to
eecc99d
Compare
msbrogli
approved these changes
Jul 25, 2024
glevco
approved these changes
Jul 25, 2024
jansegre
force-pushed
the
fix/p2p-status-regression
branch
from
eecc99d to
2a15861
Compare
This was referenced Jul 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #1086 there were some other parts that broke that weren't covered by any test.
Acceptance Criteria
.entrypoints_str()helper method that returns a list ofstrserialized entrypoints.entrypoints_str()where previously.entrypointswas used with the expectation of being a list ofstrstatusAPI and thePEER-IDmessage (when entrypoint is present)Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged