Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): mark sync-v1 and bridge as unsafe #1090

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jul 24, 2024

Motivation

We're at a point where every node is running only sync-v2, except for a few nodes that we maintain in bridge mode that run sync-v1 + sync-v2. So for the next release we can safely disincentivize sync-v1 from being used either through --sync-v1-only or --sync-bridge.

Acceptance Criteria

  • hide --sync-bridge, mark it as unsafe and unhide --x-sync-bridge (also unsafe) to be used instead
  • hide --sync-v1-only, mark it as unsafe and add --x-sync-v1-only (also unsafe) to be used instead
  • hide --sync-v2-only, since it's the default, using it will only show a warning
  • after the above, every cli option that enables sync-v1 should require --unsafe=... to be used

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jul 24, 2024
@jansegre jansegre requested a review from msbrogli as a code owner July 24, 2024 15:54
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.86%. Comparing base (631f2ca) to head (a8de807).
Report is 2 commits behind head on master.

Files Patch % Lines
hathor/builder/cli_builder.py 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1090   +/-   ##
=======================================
  Coverage   84.86%   84.86%           
=======================================
  Files         314      314           
  Lines       23898    23905    +7     
  Branches     3611     3613    +2     
=======================================
+ Hits        20280    20286    +6     
  Misses       2906     2906           
- Partials      712      713    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre requested a review from glevco July 24, 2024 16:43
@jansegre jansegre mentioned this pull request Jul 26, 2024
2 tasks
@jansegre jansegre force-pushed the chore/cli-mark-sync-v1-unsafe branch from a8de807 to 5e9c6d4 Compare July 26, 2024 21:41
@jansegre jansegre merged commit 7829afb into master Jul 26, 2024
1 check passed
@jansegre jansegre deleted the chore/cli-mark-sync-v1-unsafe branch July 26, 2024 21:42
@jansegre jansegre mentioned this pull request Aug 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants