Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flake.nix creating a devshell with all fullnode dependencies needed to run the fullnode #1098

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Jul 29, 2024

Motivation

Improve developer experience running the fullnode when using nix (with nix-flakes and direnv) by having a reproducible dev environment with fixed versions

Acceptance Criteria

  • We should have a direnv with all dependencies needed by the fullnode to run
  • We should use flake-utils to make the dev env available to all default systems supported by nixpkgs (e.g., x86_64-linux, aarch64-linux, x86_64-darwin, etc.)
  • We should use python 3.10
  • The dev env should set the poetry env python to v3.10

Future possibilities

This flake uses a hybrid approach (nix + poetry), which is fine as poetry has a rich lock file which results in deterministic installs and builds, but we could use poetry2nix to have nix also managing python dependencies. More on this here

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@andreabadesso andreabadesso self-assigned this Jul 29, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (7d3e1ec) to head (806e0b6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1098      +/-   ##
==========================================
- Coverage   84.80%   84.78%   -0.03%     
==========================================
  Files         315      315              
  Lines       24071    24071              
  Branches     3647     3647              
==========================================
- Hits        20413    20408       -5     
  Misses       2941     2941              
- Partials      717      722       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreabadesso andreabadesso force-pushed the chore/add-flake-direnv branch from 237759f to 85525f5 Compare August 16, 2024 15:12
Copy link

github-actions bot commented Aug 16, 2024

🐰Bencher

ReportWed, August 21, 2024 at 15:44:54 UTC
Projecthathor-core
Branchchore/add-flake-direnv
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,426,926,202.14 (-1.83%)82,652,997,824.79 (81.49%)123,979,496,737.19 (81.81%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@andreabadesso andreabadesso force-pushed the chore/add-flake-direnv branch 2 times, most recently from fa17355 to 7f05730 Compare August 20, 2024 15:37
@andreabadesso andreabadesso force-pushed the chore/add-flake-direnv branch from 7f05730 to 806e0b6 Compare August 21, 2024 15:42
@andreabadesso andreabadesso merged commit 72ab590 into master Aug 21, 2024
13 checks passed
@andreabadesso andreabadesso deleted the chore/add-flake-direnv branch August 21, 2024 16:33
@jansegre jansegre mentioned this pull request Oct 4, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants