-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): early protection for invalid prometheus prefix #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
force-pushed
the
feat/invalid-prometheus-prefix-protection
branch
from
August 7, 2024 14:02
f32d523
to
d18ce78
Compare
Bencher
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
- Coverage 84.87% 84.86% -0.01%
==========================================
Files 315 315
Lines 24059 24070 +11
Branches 3644 3647 +3
==========================================
+ Hits 20419 20428 +9
- Misses 2927 2929 +2
Partials 713 713 ☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
Aug 9, 2024
glevco
requested changes
Aug 12, 2024
jansegre
force-pushed
the
feat/invalid-prometheus-prefix-protection
branch
from
August 14, 2024 15:48
d18ce78
to
0f99e75
Compare
glevco
approved these changes
Aug 14, 2024
msbrogli
approved these changes
Aug 14, 2024
jansegre
force-pushed
the
feat/invalid-prometheus-prefix-protection
branch
from
August 14, 2024 16:34
0f99e75
to
e9b57d6
Compare
jansegre
force-pushed
the
feat/invalid-prometheus-prefix-protection
branch
from
August 15, 2024 13:05
e9b57d6
to
79c03e9
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We had a report from someone accidentally using an invalid prefix through
HATHOR_PROMETHEUS_PREFIX
which had a message that was hard to understand.Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged