refactor(p2p): rename peer_id.PeerId to peer.Peer #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Report | Thu, August 22, 2024 at 14:04:50 UTC |
| Project | hathor-core |
| Branch | refactor/p2p-rename-peer-id |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,385,519,316.14 (-1.46%) | 92,595,867,200.35 (91.33%) | 113,172,726,578.21 (89.58%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 84.86% 84.91% +0.05%
==========================================
Files 315 315
Lines 24071 24071
Branches 3647 3647
==========================================
+ Hits 20427 20440 +13
+ Misses 2931 2920 -11
+ Partials 713 711 -2 ☔ View full report in Codecov by Sentry. |
msbrogli
requested changes
Aug 20, 2024
jansegre
force-pushed
the
refactor/p2p-rename-peer-id
branch
2 times, most recently
from
945e51d to
eb6c3d7
Compare
glevco
reviewed
Aug 22, 2024
glevco
approved these changes
Aug 22, 2024
msbrogli
approved these changes
Aug 22, 2024
jansegre
force-pushed
the
refactor/p2p-rename-peer-id
branch
from
eb6c3d7 to
f2c436f
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is the first part of a series of refactors. This first refactor is a step to make using
PeerIdfor only theidpart ofPeer.Acceptance Criteria
hathor.p2p.peer_id.PeerIdtohathor.p2p.peer.PeerChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged