feat: enable cache by default #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jansegre
previously approved these changes
Aug 28, 2024
jansegre
previously approved these changes
Aug 28, 2024
|
| Report | Tue, September 3, 2024 at 22:29:47 UTC |
| Project | hathor-core |
| Branch | feat/invert-cache-option |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,422,677,378.16 (-0.81%) | 92,027,490,789.67 (90.74%) | 112,478,044,298.49 (90.17%) |
Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
msbrogli
reviewed
Aug 28, 2024
msbrogli
previously approved these changes
Aug 28, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1125 +/- ##
==========================================
- Coverage 84.50% 84.36% -0.15%
==========================================
Files 317 317
Lines 24231 24240 +9
Branches 3680 3684 +4
==========================================
- Hits 20477 20449 -28
- Misses 3050 3075 +25
- Partials 704 716 +12 ☔ View full report in Codecov by Sentry. |
msbrogli
approved these changes
Aug 29, 2024
jansegre
approved these changes
Sep 2, 2024
glevco
force-pushed
the
feat/invert-cache-option
branch
from
23fb591 to
7a4f2db
Compare
msbrogli
approved these changes
Sep 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We almost always run the full node with tx storage cache enabled, and running it without it is impractical for production. Therefore, we must invert the CLI option so cache is enabled by default.
Acceptance Criteria
--cacheand adding--disable-cache.100000as the default value for cache size.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged