feat: improve load-from-logs CLI command #1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
load-from-logs
CLI command reads a raw logs file as outputted by a full node. This PR changes it so instead you have to process the log file with theparse-logs
command, only then to use it withload-from-logs
. This makes the log files much smaller, as the parser strips every information but the vertex bytes.Also, previously that command only called
on_new_tx
in a loop, but didn't actually run the reactor or the full node itself. This PR also changes this.The new intended workflow would be something like this:
Acceptance Criteria
parse-logs
CLI command.load-from-logs
CLI command so it takes files fromparse-logs
and so it actually runs a full node.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged