-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(p2p): remove HathorManager and P2PManager dependencies [part 7/11] #1142
Open
glevco
wants to merge
1
commit into
refactor/p2p/dependencies
Choose a base branch
from
refactor/p2p/remove-manager
base: refactor/p2p/dependencies
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef30b40
to
4f6d4a7
Compare
49b6c56
to
4f5686d
Compare
f3497d2
to
2914d58
Compare
ea8619c
to
1c7546d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/p2p/dependencies #1142 +/- ##
=============================================================
- Coverage 84.85% 84.72% -0.13%
=============================================================
Files 320 320
Lines 24462 24457 -5
Branches 3709 3718 +9
=============================================================
- Hits 20757 20721 -36
- Misses 2990 3004 +14
- Partials 715 732 +17 ☔ View full report in Codecov by Sentry. |
e5478b7
to
d972adf
Compare
1c7546d
to
a484984
Compare
d972adf
to
747ae1c
Compare
a484984
to
229d017
Compare
747ae1c
to
729cdd4
Compare
229d017
to
1d77698
Compare
729cdd4
to
3aa3acd
Compare
b204c2c
to
2af3b11
Compare
1 task
3aa3acd
to
58f7e16
Compare
854175c
to
a48a6ae
Compare
6e13bb7
to
0b86412
Compare
a48a6ae
to
dfec58a
Compare
0b86412
to
81565b1
Compare
a2e3a0a
to
ef65374
Compare
81565b1
to
e7a4cf1
Compare
afffb92
to
e0fb633
Compare
10c2ec4
to
b6b19b2
Compare
1 task
e0fb633
to
d12e8b0
Compare
b6b19b2
to
58633dc
Compare
1 task
d12e8b0
to
8e22ef6
Compare
58633dc
to
e9616e9
Compare
8e22ef6
to
56993b9
Compare
e9616e9
to
45ede7d
Compare
56993b9
to
1fff2ad
Compare
45ede7d
to
bf1e568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1152
Motivation
Continuing with the multiprocess P2P refactors, this PR introduces the
P2PManagerProtocol
to abstract the existingConnectionsManager
. This will make it easier to perform IPC calls from individual connections (HathorProtocol
instances) to the connections manager. It also removes theHathorManager
dependency fromHathorProtocol
.Acceptance Criteria
P2PManagerProtocol
.origin
parameter fromon_receive_peer
(it's not used).ConnectionsManager
fromNetfilterContext
andNetfilterFactory
(it's not used).HathorManager
fromHathorProtocol
.HathorProtocol
to receive aP2PManagerProtocol
instead of aConnectionsManager
.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged