Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): subcommand quick_test not stopping after #1115 #1147

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Oct 8, 2024

Motivation

After #1115 was merged there was a regression in the docker build CI: https://github.com/HathorNetwork/hathor-core/actions/runs/11223644493/job/31198706926 which is basically the quick_test failing to stop. Which happened because quick_test monkey-patches HathorManger.on_new_tx in order to stop, but that method is no longer used after #1115

Acceptance Criteria

  • Make VertexHandlerWrapper class that adds the stopping logic to on_new_vertex

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre requested a review from glevco October 8, 2024 16:37
@jansegre jansegre self-assigned this Oct 8, 2024
@jansegre jansegre requested a review from msbrogli as a code owner October 8, 2024 16:37
Copy link

github-actions bot commented Oct 8, 2024

🐰 Bencher Report

Branchfix/quick_test-regression
Testbedubuntu-22.04

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
sync-v2 (up to 20000 blocks)📈 view plot
⚠️ NO THRESHOLD
101,437,773,544.08
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.44%. Comparing base (22f478c) to head (c7cd0a7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1147      +/-   ##
==========================================
- Coverage   84.50%   84.44%   -0.06%     
==========================================
  Files         317      317              
  Lines       24384    24389       +5     
  Branches     3707     3709       +2     
==========================================
- Hits        20606    20596      -10     
- Misses       3069     3076       +7     
- Partials      709      717       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre force-pushed the fix/quick_test-regression branch from c7cd0a7 to 4c13fdd Compare October 8, 2024 17:26
@jansegre jansegre merged commit daf12e7 into master Oct 11, 2024
12 of 13 checks passed
@jansegre jansegre deleted the fix/quick_test-regression branch October 11, 2024 16:39
@jansegre jansegre mentioned this pull request Oct 14, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants