refactor(settings): change wallets and reward lock to use injected settings #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 84.45% 84.38% -0.07%
==========================================
Files 317 317
Lines 24365 24368 +3
Branches 3708 3708
==========================================
- Hits 20577 20563 -14
- Misses 3076 3086 +10
- Partials 712 719 +7 ☔ View full report in Codecov by Sentry. |
msbrogli
previously approved these changes
Oct 10, 2024
glevco
force-pushed
the
refactor/static-metadata/undo-feature-states
branch
2 times, most recently
from
b1d9f54 to
f179ea7
Compare
glevco
force-pushed
the
refactor/settings/wallets-and-reward-lock
branch
from
5d41130 to
5b442d6
Compare
jansegre
previously approved these changes
Oct 11, 2024
glevco
force-pushed
the
refactor/static-metadata/undo-feature-states
branch
from
f179ea7 to
b8584e2
Compare
glevco
force-pushed
the
refactor/settings/wallets-and-reward-lock
branch
from
5b442d6 to
b8c3f63
Compare
glevco
force-pushed
the
refactor/static-metadata/undo-feature-states
branch
from
b8584e2 to
2d27cd1
Compare
glevco
force-pushed
the
refactor/settings/wallets-and-reward-lock
branch
from
b8c3f63 to
7048b1d
Compare
Base automatically changed from
refactor/static-metadata/undo-feature-states
to
master
October 14, 2024 03:37
glevco
dismissed stale reviews from jansegre and msbrogli
The base branch was changed.
glevco
force-pushed
the
refactor/settings/wallets-and-reward-lock
branch
from
7048b1d to
82f8e5d
Compare
|
Bencher Report| Branch | refactor/settings/wallets-and-reward-lock |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,435,075,123.16 (-0.44%) | 91,692,692,801.72 (90.40%) | 112,068,846,757.65 (90.51%) |
jansegre
approved these changes
Oct 14, 2024
msbrogli
approved these changes
Oct 16, 2024
glevco
force-pushed
the
refactor/settings/wallets-and-reward-lock
branch
from
82f8e5d to
391c9f0
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1146
Motivation
Remove global settings from reward lock and test wallets. This will be useful for Feature Activation for Transaction tests.
Acceptance Criteria
HathorSettings.HATHOR_TOKEN_UIDto a constant.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged