chore: remove all migrations #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
glevco
force-pushed
the
feat/feature-activation/txs-closest-block
branch
8 times, most recently
from
32a353c to
f1cfe85
Compare
glevco
force-pushed
the
feat/feature-activation/txs-closest-block
branch
from
f1cfe85 to
aacdccf
Compare
glevco
force-pushed
the
chore/remove-migrations
branch
from
1b46a82 to
1f40718
Compare
glevco
changed the title
glevco
changed the base branch from
feat/feature-activation/txs-closest-block
to
master
glevco
force-pushed
the
chore/remove-migrations
branch
from
1f40718 to
330bc52
Compare
glevco
force-pushed
the
chore/remove-migrations
branch
from
330bc52 to
9cebb0e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1149 +/- ##
==========================================
+ Coverage 84.52% 84.54% +0.01%
==========================================
Files 319 313 -6
Lines 24389 24245 -144
Branches 3706 3687 -19
==========================================
- Hits 20616 20497 -119
+ Misses 3063 3023 -40
- Partials 710 725 +15 ☔ View full report in Codecov by Sentry. |
jansegre
force-pushed
the
feat/score-acc-weight-types
branch
from
17eac7c to
26a36c0
Compare
msbrogli
previously approved these changes
Oct 23, 2024
glevco
force-pushed
the
chore/remove-migrations
branch
from
9cebb0e to
e169fe9
Compare
jansegre
previously approved these changes
Oct 23, 2024
jansegre
dismissed stale reviews from msbrogli and themself
The base branch was changed.
glevco
force-pushed
the
chore/remove-migrations
branch
from
e169fe9 to
741ee86
Compare
jansegre
approved these changes
Oct 24, 2024
|
Bencher Report| Branch | chore/remove-migrations |
| Testbed | ubuntu-22.04 |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚷 view threshold | 101,385,504,176.32 (-0.81%) | 91,992,411,431.94 (90.74%) | 112,435,169,527.93 (90.17%) |
msbrogli
approved these changes
Oct 24, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #572
Motivation
Remove all migrations that are not necessary any more since PR #572 will introduce an incompatible migration.
Acceptance Criteria
Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged