refactor(p2p): simplify factory [part 1/5] #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
force-pushed
the
refactor/p2p/simplify-factory
branch
5 times, most recently
from
3967a8f to
48a4de4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1151 +/- ##
==========================================
- Coverage 84.46% 84.45% -0.02%
==========================================
Files 317 317
Lines 24389 24365 -24
Branches 3709 3708 -1
==========================================
- Hits 20600 20577 -23
+ Misses 3075 3074 -1
Partials 714 714 ☔ View full report in Codecov by Sentry. |
glevco
changed the title
1 task
msbrogli
approved these changes
Oct 11, 2024
jansegre
approved these changes
Oct 14, 2024
glevco
force-pushed
the
refactor/p2p/simplify-factory
branch
from
48a4de4 to
c85752d
Compare
|
Bencher Report| Branch | refactor/p2p/simplify-factory |
| Testbed | ubuntu-22.04 |
⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsCLI flag.
Click to view all benchmark results
| Benchmark | Latency | nanoseconds (ns) |
|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot | 101,468,340,229.32 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR contains some useful pre-refactors for the P2P Multiprocess project.
Acceptance Criteria
networkparameter from multiple classes. They usesettings.NETWORK_NAMEinstead.p2p/factory.py, unifying client and server factories in a base class to simplify it.traversalmodule so it can receive the more flexibleVertexStorageProtocolinstead of aTransactionStorage.Checklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged