Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use macos-13 on Github Actions as macos-12 will be dropped #1185

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Nov 18, 2024

Motivation

The macos-12 runner will be dropped by Github Actions: actions/runner-images#10721

Acceptance Criteria

  • We should use macos-13 instead. There are newer ones, but I preferred the safe path of just one version up.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@luislhl luislhl self-assigned this Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

🐰 Bencher Report

Branchci/upgrade-macos-version
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)
Lower Boundary
nanoseconds (ns)
(Limit %)
Upper Boundary
nanoseconds (ns)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
101,399,521,771.76
(-0.34%)
91,571,153,925.24
(90.31%)
111,920,299,241.96
(90.60%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (9822bdb) to head (20410ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1185      +/-   ##
==========================================
+ Coverage   84.89%   84.93%   +0.04%     
==========================================
  Files         323      323              
  Lines       24984    24984              
  Branches     3834     3834              
==========================================
+ Hits        21210    21220      +10     
+ Misses       3034     3025       -9     
+ Partials      740      739       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@luislhl luislhl enabled auto-merge (squash) November 18, 2024 19:01
@luislhl luislhl disabled auto-merge November 18, 2024 19:01
@luislhl luislhl force-pushed the ci/upgrade-macos-version branch from 5b72f28 to 2d3830d Compare November 18, 2024 20:55
@luislhl luislhl enabled auto-merge (squash) November 18, 2024 20:56
Signed-off-by: Luis Helder <luislhl@gmail.com>
@luislhl luislhl force-pushed the ci/upgrade-macos-version branch from 2d3830d to 20410ab Compare November 18, 2024 20:57
@luislhl luislhl merged commit dc3c7ca into master Nov 18, 2024
10 checks passed
@luislhl luislhl deleted the ci/upgrade-macos-version branch November 18, 2024 21:38
@jansegre jansegre mentioned this pull request Nov 21, 2024
2 tasks
@jansegre jansegre mentioned this pull request Dec 11, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants