chore(docker): include python suffix tags on rc images #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glevco
previously approved these changes
Dec 11, 2024
|
Bencher Report| Branch | chore/rc-include-python-suffix |
| Testbed | ubuntu-22.04 |
🚨 1 Alert
| Benchmark | Measure Units | View | Benchmark Result (Result Δ%) | Lower Boundary (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | Latency nanoseconds (ns) | 📈 plot 🚨 alert (🔔) 🚷 threshold | 82,874,414,981.34 (-16.59%) | 89,423,483,320.23 (107.90%) |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Lower Boundary nanoseconds (ns) (Limit %) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|---|
| sync-v2 (up to 20000 blocks) | 📈 view plot 🚨 view alert (🔔) 🚷 view threshold | 82,874,414,981.34 (-16.59%) | 89,423,483,320.23 (107.90%) | 109,295,368,502.50 (75.83%) |
luislhl
previously approved these changes
Dec 11, 2024
jansegre
force-pushed
the
chore/rc-include-python-suffix
branch
from
d6d34f7 to
c57826b
Compare
jansegre
force-pushed
the
chore/rc-include-python-suffix
branch
from
c57826b to
f893765
Compare
glevco
approved these changes
Dec 11, 2024
luislhl
approved these changes
Dec 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1194 +/- ##
==========================================
- Coverage 84.95% 84.87% -0.08%
==========================================
Files 323 323
Lines 25115 25115
Branches 3859 3859
==========================================
- Hits 21336 21316 -20
- Misses 3036 3050 +14
- Partials 743 749 +6 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I couldn't use
-python3.12suffix on the release candidate image for testing.Acceptance Criteria
-python{Version}tags even for rc imagesChecklist
master, confirm this code is production-ready and can be included in future releases as soon as it gets merged