Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(p2p): decrease p2p.max_enabled_sync's default value: 16 -> 8 #1199

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Jan 6, 2025

Motivation

The default value of 16 can be slower than expected in certain cases.

Acceptance Criteria

  • Reduce the default value to 8, it can still be adjusted through the settings and even in runtime through sysctl.

Checklist

  • If you are requesting a merge into master, confirm this code is production-ready and can be included in future releases as soon as it gets merged

@jansegre jansegre self-assigned this Jan 6, 2025
@jansegre jansegre requested a review from msbrogli as a code owner January 6, 2025 14:08
Copy link

github-actions bot commented Jan 6, 2025

🐰 Bencher Report

Branchchore/reduce-max-enabled-sync
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
minutes (m)
(Result Δ%)
Lower Boundary
minutes (m)
(Limit %)
Upper Boundary
minutes (m)
(Limit %)
sync-v2 (up to 20000 blocks)📈 view plot
🚷 view threshold
1.52
(-8.55%)
1.49
(98.42%)
1.82
(83.13%)
🐰 View full continuous benchmarking report in Bencher

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.94%. Comparing base (692a74c) to head (9247743).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1199   +/-   ##
=======================================
  Coverage   84.93%   84.94%           
=======================================
  Files         323      323           
  Lines       25124    25124           
  Branches     3859     3859           
=======================================
+ Hits        21340    21342    +2     
+ Misses       3041     3039    -2     
  Partials      743      743           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jansegre jansegre merged commit b17a8be into master Jan 8, 2025
10 checks passed
@jansegre jansegre deleted the chore/reduce-max-enabled-sync branch January 8, 2025 14:16
This was referenced Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants