Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add --unsafe-mode argument to run_node #278

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Jul 27, 2021

--unsafe-mode with no unsafe argument

image

--test-mode-tx-weight with --unsafe-mode

image

Error using --test-mode-tx-weight without --unsafe-mode

image

@msbrogli msbrogli added the enhancement New feature or request label Jul 27, 2021
@msbrogli msbrogli requested a review from jansegre July 27, 2021 23:18
@msbrogli msbrogli self-assigned this Jul 27, 2021
@msbrogli msbrogli requested a review from pedroferreira1 July 27, 2021 23:26
hathor/cli/run_node.py Outdated Show resolved Hide resolved
hathor/cli/run_node.py Outdated Show resolved Hide resolved
@msbrogli msbrogli force-pushed the feat/unsafe-mode branch 4 times, most recently from 038db85 to dce2943 Compare July 27, 2021 23:42
@msbrogli msbrogli changed the title feat(cli): Add --unsafe-mode argumento to run_node feat(cli): Add --unsafe-mode argument to run_node Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #278 (d064f49) into dev (a6d9933) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #278   +/-   ##
=======================================
  Coverage   82.42%   82.42%           
=======================================
  Files         149      149           
  Lines       14116    14116           
  Branches     2014     2014           
=======================================
  Hits        11635    11635           
  Misses       2065     2065           
  Partials      416      416           
Impacted Files Coverage Δ
hathor/p2p/node_sync.py 83.04% <0.00%> (-0.50%) ⬇️
hathor/consensus.py 93.48% <0.00%> (+0.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d9933...d064f49. Read the comment docs.

@msbrogli msbrogli force-pushed the feat/unsafe-mode branch 5 times, most recently from 65f9e7f to a715b59 Compare July 28, 2021 00:08
@msbrogli msbrogli merged commit 7271e0c into dev Jul 28, 2021
@msbrogli msbrogli deleted the feat/unsafe-mode branch July 28, 2021 02:31
@jansegre jansegre mentioned this pull request Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants