Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tests): assertConsensusEqual() must convert conflict_with to a set for comparison #282

Merged
merged 2 commits into from
Jul 30, 2021
Merged

fix(tests): assertConsensusEqual() must convert conflict_with to a set for comparison #282

merged 2 commits into from
Jul 30, 2021

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Jul 29, 2021 •
edited
Loading

Fixes #279.

@msbrogli msbrogli added the bug Something isn't working label Jul 29, 2021
@msbrogli msbrogli self-assigned this Jul 29, 2021
@msbrogli msbrogli changed the title fix(tests): assertConsensusEqual() must convert conflict_with to a se… fix(tests): assertConsensusEqual() must convert conflict_with to a set for comparison Jul 29, 2021
@msbrogli msbrogli mentioned this pull request Jul 29, 2021
Closed
@codecov
Copy link

codecov bot commented Jul 29, 2021 •
edited
Loading

Codecov Report

Merging #282 (eac9d82) into dev (2c01023) will not change coverage.
The diff coverage is n/a.

❗ Current head eac9d82 differs from pull request most recent head 2531d8f. Consider uploading reports for the commit 2531d8f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #282   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         152      152           
  Lines       14408    14408           
  Branches     2056     2056           
=======================================
  Hits        11838    11838           
  Misses       2132     2132           
  Partials      438      438

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c01023...2531d8f. Read the comment docs.

@msbrogli msbrogli force-pushed the fix/tests-assertConsensusEqual branch from 2fc1998 to b3f03fe Compare July 29, 2021 23:52
@msbrogli msbrogli force-pushed the fix/tests-assertConsensusEqual branch from b3f03fe to 2531d8f Compare July 29, 2021 23:53
@msbrogli msbrogli merged commit cee7191 into dev Jul 30, 2021
@msbrogli msbrogli deleted the fix/tests-assertConsensusEqual branch July 30, 2021 00:49
@jansegre jansegre mentioned this pull request Aug 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@msbrogli msbrogli

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msbrogli @jansegre @pedroferreira1