Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db): testnet-golf and prevent mixing networks #342

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Dec 9, 2021

Acceptance criteria: after this version is in use (i.e., after nodes have upgraded), a database used on the mainnet should be rejected immediately when trying to use it for the testnet, and vice-versa; additionally when upgrading mainnet should be implied, but testnet-golf must be explicit (i.e., do not try to "import" a testnet-foxtrot database).

@jansegre jansegre self-assigned this Dec 9, 2021
@jansegre jansegre requested a review from msbrogli as a code owner December 9, 2021 18:07
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #342 (dcebfee) into dev (2897e77) will decrease coverage by 0.04%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #342      +/-   ##
==========================================
- Coverage   82.11%   82.06%   -0.05%     
==========================================
  Files         153      153              
  Lines       14464    14489      +25     
  Branches     2080     2086       +6     
==========================================
+ Hits        11877    11891      +14     
- Misses       2161     2168       +7     
- Partials      426      430       +4     
Impacted Files Coverage Δ
hathor/conf/testnet.py 100.00% <ø> (ø)
hathor/transaction/storage/transaction_storage.py 87.05% <68.00%> (-0.59%) ⬇️
hathor/transaction/storage/exceptions.py 100.00% <100.00%> (ø)
hathor/p2p/manager.py 68.28% <0.00%> (-1.50%) ⬇️
hathor/p2p/node_sync.py 83.45% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9c41af...dcebfee. Read the comment docs.

Copy link
Collaborator

@luislhl luislhl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks great

@jansegre jansegre force-pushed the feat/prevent-mixing-networks branch 2 times, most recently from 223237f to 324830c Compare December 9, 2021 21:49
@jansegre jansegre force-pushed the feat/prevent-mixing-networks branch from 324830c to 4a3ba21 Compare December 10, 2021 01:06
@jansegre jansegre force-pushed the feat/prevent-mixing-networks branch from 4a3ba21 to dcebfee Compare December 10, 2021 01:09
@jansegre jansegre merged commit b33f427 into dev Dec 10, 2021
@jansegre jansegre deleted the feat/prevent-mixing-networks branch December 10, 2021 03:54
@jansegre jansegre mentioned this pull request Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants