-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(db): testnet-golf and prevent mixing networks #342
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #342 +/- ##
==========================================
- Coverage 82.11% 82.06% -0.05%
==========================================
Files 153 153
Lines 14464 14489 +25
Branches 2080 2086 +6
==========================================
+ Hits 11877 11891 +14
- Misses 2161 2168 +7
- Partials 426 430 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks great
223237f
to
324830c
Compare
324830c
to
4a3ba21
Compare
4a3ba21
to
dcebfee
Compare
Acceptance criteria: after this version is in use (i.e., after nodes have upgraded), a database used on the mainnet should be rejected immediately when trying to use it for the testnet, and vice-versa; additionally when upgrading mainnet should be implied, but testnet-golf must be explicit (i.e., do not try to "import" a testnet-foxtrot database).