Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove peers that were disconnected and cant be reconnected anymore #365

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

pedroferreira1
Copy link
Member

Motivation

https://github.com/HathorNetwork/internal-issues/issues/73

Acceptance criteria

Peers that have no entrypoints and have disconnected must be removed from the known peers list because there is no more use for them.

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #365 (b675333) into dev (79e47aa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #365   +/-   ##
=======================================
  Coverage   82.76%   82.77%           
=======================================
  Files         166      166           
  Lines       15175    15181    +6     
  Branches     2144     2146    +2     
=======================================
+ Hits        12560    12566    +6     
  Misses       2182     2182           
  Partials      433      433           
Impacted Files Coverage Δ
hathor/p2p/manager.py 70.00% <100.00%> (+0.22%) ⬆️
hathor/p2p/peer_storage.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e47aa...b675333. Read the comment docs.

@pedroferreira1 pedroferreira1 force-pushed the feat/remove-unused-disconnected-peer branch from c9c1526 to b675333 Compare January 13, 2022 13:18
@pedroferreira1 pedroferreira1 merged commit aa1780c into dev Jan 13, 2022
@pedroferreira1 pedroferreira1 deleted the feat/remove-unused-disconnected-peer branch January 13, 2022 14:24
@jansegre jansegre mentioned this pull request Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants