Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): mark flaky tests #400

Merged
merged 1 commit into from
Apr 28, 2022
Merged

chore(tests): mark flaky tests #400

merged 1 commit into from
Apr 28, 2022

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Apr 27, 2022

These tests were added recently and they both use the simulator in a way that will sometimes fail, which has nothing to do with what is being tested. I think it makes sense to have them as flaky and avoid having to re-run the failed jobs when it occasionally happens.

@jansegre jansegre self-assigned this Apr 27, 2022
@jansegre jansegre requested a review from msbrogli as a code owner April 27, 2022 21:33
@jansegre jansegre force-pushed the chore/mark-flaky-tests branch 2 times, most recently from 4651106 to ce96133 Compare April 27, 2022 21:54
@codecov
Copy link

codecov bot commented Apr 27, 2022

Codecov Report

Merging #400 (88764be) into dev (9b1c3b6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev     #400      +/-   ##
==========================================
- Coverage   82.84%   82.82%   -0.02%     
==========================================
  Files         171      171              
  Lines       15585    15585              
  Branches     2466     2466              
==========================================
- Hits        12912    12909       -3     
- Misses       2227     2228       +1     
- Partials      446      448       +2     
Impacted Files Coverage Δ
hathor/indexes/manager.py 92.85% <0.00%> (-0.90%) ⬇️
hathor/p2p/node_sync.py 83.53% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b1c3b6...88764be. Read the comment docs.

@jansegre jansegre requested a review from pedroferreira1 April 28, 2022 15:59
@jansegre jansegre force-pushed the chore/mark-flaky-tests branch from ce96133 to 88764be Compare April 28, 2022 16:07
@jansegre jansegre requested review from luislhl and removed request for msbrogli April 28, 2022 16:19
@jansegre jansegre enabled auto-merge April 28, 2022 16:23
@jansegre jansegre disabled auto-merge April 28, 2022 18:56
@jansegre jansegre merged commit 93cd789 into dev Apr 28, 2022
@jansegre jansegre deleted the chore/mark-flaky-tests branch April 28, 2022 18:59
@jansegre jansegre mentioned this pull request May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants