Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(indexes): partial optimization of tips indexes using rocksdb #480

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jansegre
Copy link
Member

@jansegre jansegre commented Sep 2, 2022

This is how it looks like on my machine, while still loading the deps and mempool indexes:

2022-09-15 13:59:03 [info     ] [hathor.cli.run_node] hathor-core v0.50.2            genesis=3fdff62 hathor=0.50.2 my_peer_id=7181d232a16ba95001de22d3151b027ed31677c8cd6dc7eb88d538b250186bbf pid=5375 platform=macOS-12.5.1-arm64-arm-64bit python=3.10.4-CPython settings=/Users/jan/Projects/hathor-nodes/data-1/conf.py
2022-09-15 13:59:04 [info     ] [hathor.cli.run_node] with storage                   path=/Users/jan/Projects/hathor-nodes/data-1 storage_class=TransactionRocksDBStorage
2022-09-15 13:59:04 [info     ] [hathor.cli.run_node] with cache                     capacity=100000 interval=5
2022-09-15 13:59:04 [info     ] [hathor.cli.run_node] with indexes                   indexes_class=RocksDBIndexesManager
2022-09-15 13:59:04 [info     ] [hathor.manager] start manager                  network=mainnet
2022-09-15 13:59:04 [info     ] [hathor.p2p.manager] update whitelist
2022-09-15 13:59:04 [info     ] [hathor.manager] initialize
2022-09-15 13:59:04 [info     ] [hathor.indexes.rocksdb_info_index] loaded info-index              block_count=2807811 first_timestamp=1578075305 latest_timestamp=1662516907 tx_count=922252
2022-09-15 13:59:34 [info     ] [hathor.indexes.memory_tips_index] loading... 24%                 dt=~30s index=tips-all iv_new=909006 progress=0.24369722441685301 rate=30300.184829333273 total=909006
2022-09-15 14:00:04 [info     ] [hathor.indexes.memory_tips_index] loading... 46%                 dt=~30s index=tips-all iv_new=816775 progress=0.46266805681298145 rate=27225.80066127857 total=1725781
2022-09-15 14:00:35 [info     ] [hathor.indexes.memory_tips_index] loading... 68%                 dt=~31s index=tips-all iv_new=814892 progress=0.6811340719982477 rate=25798.856720781867 total=2540673
2022-09-15 14:01:05 [info     ] [hathor.indexes.memory_tips_index] loading... 89%                 dt=~30s index=tips-all iv_new=806658 progress=0.8973926177654372 rate=26888.581195170522 total=3347331
2022-09-15 14:01:17 [info     ] [hathor.indexes.memory_tips_index] loaded                         count=3730063 index=tips-all rate=27950.76172580169 total_dt=~133s
2022-09-15 14:01:47 [info     ] [hathor.indexes.memory_tips_index] loading... 31%                 dt=~30s index=tips-blocks iv_new=879079 progress=0.3130833948581297 rate=29302.614703232637 total=879079
2022-09-15 14:02:17 [info     ] [hathor.indexes.memory_tips_index] loading... 59%                 dt=~30s index=tips-blocks iv_new=783784 progress=0.592227539531685 rate=26126.1204601648 total=1662863
2022-09-15 14:02:51 [info     ] [hathor.indexes.memory_tips_index] loading... 88%                 dt=~33s index=tips-blocks iv_new=818442 progress=0.8837151076051771 rate=24364.050150816678 total=2481305
2022-09-15 14:03:01 [info     ] [hathor.indexes.memory_tips_index] loaded                         count=2807811 index=tips-blocks rate=27093.169051009627 total_dt=~103s
2022-09-15 14:03:25 [info     ] [hathor.indexes.memory_tips_index] loaded                         count=920975 index=tips-txs rate=37363.693979994045 total_dt=~24s
2022-09-15 14:03:55 [info     ] [hathor.indexes.manager] loading...  7%                 dt=~30s height=297850 latest_ts=2020-04-16 16:21:01 progress=0.0799721214742237 total=299940 tx_new=299940 tx_rate=9997.994040731168
2022-09-15 14:04:25 [info     ] [hathor.indexes.manager] loading... 12%                 dt=~30s height=479907 latest_ts=2020-06-19 07:16:23 progress=0.1289576454910564 total=483663 tx_new=183723 tx_rate=6124.077563224183
2022-09-15 14:04:55 [info     ] [hathor.indexes.manager] loading... 16%                 dt=~30s height=617646 latest_ts=2020-08-06 11:12:02 progress=0.1666741766622931 total=625121 tx_new=141458 tx_rate=4715.253925686401
2022-09-15 14:05:25 [info     ] [hathor.indexes.manager] loading... 20%                 dt=~30s height=771193 latest_ts=2020-09-29 01:39:06 progress=0.20942356028717868 total=785455 tx_new=160334 tx_rate=5344.455113762292
2022-09-15 14:05:55 [info     ] [hathor.indexes.manager] loading... 26%                 dt=~30s height=954518 latest_ts=2020-12-02 13:43:08 progress=0.26007257055418703 total=975417 tx_new=189962 tx_rate=6332.0645531121
2022-09-15 14:06:25 [info     ] [hathor.indexes.manager] loading... 30%                 dt=~30s height=1121808 latest_ts=2021-01-30 02:47:34 progress=0.3086173600347895 total=1157487 tx_new=182070 tx_rate=6068.893553669667
2022-09-15 14:06:55 [info     ] [hathor.indexes.manager] loading... 35%                 dt=~30s height=1275407 latest_ts=2021-03-24 18:21:56 progress=0.35380211525914684 total=1326955 tx_new=169468 tx_rate=5648.924130142159
2022-09-15 14:07:25 [info     ] [hathor.indexes.manager] loading... 39%                 dt=~30s height=1420990 latest_ts=2021-05-14 17:31:43 progress=0.39838296018431396 total=1494158 tx_new=167203 tx_rate=5573.414552881158
2022-09-15 14:07:55 [info     ] [hathor.indexes.manager] loading... 44%                 dt=~30s height=1573695 latest_ts=2021-07-07 06:13:56 progress=0.4442673448237155 total=1666250 tx_new=172092 tx_rate=5736.398677924779
2022-09-15 14:08:25 [info     ] [hathor.indexes.manager] loading... 48%                 dt=~30s height=1722635 latest_ts=2021-08-28 14:37:37 progress=0.4894643648930012 total=1835764 tx_new=169514 tx_rate=5650.461233061082
2022-09-15 14:08:55 [info     ] [hathor.indexes.manager] loading... 53%                 dt=~30s height=1823709 latest_ts=2021-10-02 22:36:46 progress=0.5360449127956194 total=2010467 tx_new=174703 tx_rate=5823.417366608051
2022-09-15 14:09:25 [info     ] [hathor.indexes.manager] loading... 58%                 dt=~30s height=1922761 latest_ts=2021-11-06 11:39:14 progress=0.5801818236597924 total=2176005 tx_new=165538 tx_rate=5517.920484553162
2022-09-15 14:09:55 [info     ] [hathor.indexes.manager] loading... 62%                 dt=~30s height=2005821 latest_ts=2021-12-05 08:33:38 progress=0.6222713053021192 total=2333864 tx_new=157859 tx_rate=5261.955417553526
2022-09-15 14:10:25 [info     ] [hathor.indexes.manager] loading... 66%                 dt=~30s height=2081582 latest_ts=2021-12-31 16:38:10 progress=0.6655603421038528 total=2496222 tx_new=162358 tx_rate=5411.917849712166
2022-09-15 14:10:55 [info     ] [hathor.indexes.manager] loading... 71%                 dt=~30s height=2162280 latest_ts=2022-01-28 18:15:33 progress=0.7125674933083272 total=2672525 tx_new=176303 tx_rate=5876.745462970414
2022-09-15 14:11:25 [info     ] [hathor.indexes.manager] loading... 75%                 dt=~30s height=2237488 latest_ts=2022-02-23 22:06:19 progress=0.7592890869276216 total=2847757 tx_new=175232 tx_rate=5841.065877516111
2022-09-15 14:11:55 [info     ] [hathor.indexes.manager] loading... 80%                 dt=~30s height=2325919 latest_ts=2022-03-26 18:34:36 progress=0.8050593551837767 total=3019421 tx_new=171664 tx_rate=5722.109913582758
2022-09-15 14:12:25 [info     ] [hathor.indexes.manager] loading... 85%                 dt=~30s height=2424766 latest_ts=2022-04-30 07:00:50 progress=0.8511021162989924 total=3192107 tx_new=172686 tx_rate=5756.191171003215
2022-09-15 14:12:55 [info     ] [hathor.indexes.manager] loading... 89%                 dt=~30s height=2535767 latest_ts=2022-06-08 01:28:46 progress=0.8976232063664144 total=3366587 tx_new=174480 tx_rate=5815.9949618701075
2022-09-15 14:13:25 [info     ] [hathor.indexes.manager] loading... 94%                 dt=~30s height=2654734 latest_ts=2022-07-19 14:06:25 progress=0.9418105097456191 total=3532314 tx_new=165727 tx_rate=5524.231708935315
2022-09-15 14:13:55 [info     ] [hathor.indexes.manager] loading... 98%                 dt=~30s height=2774940 latest_ts=2022-08-30 13:17:23 progress=0.9865409324534996 total=3700078 tx_new=167764 tx_rate=5592.117289715277
2022-09-15 14:14:20 [info     ] [hathor.indexes.manager] loaded                         blocks=2807811 height=2796758 total_dt=~654s tx_count=3730063 tx_rate=5700.653006275316 txs=922252
2022-09-15 14:14:21 [info     ] [hathor.manager] ready
2022-09-15 14:14:21 [info     ] [hathor.metrics] Transaction cache hits during initialization hits=10882
2022-09-15 14:14:21 [info     ] [hathor.metrics] Transaction cache misses during initialization misses=3741080
2022-09-15 14:14:21 [info     ] [hathor.p2p.manager] listen on                      endpoint=tcp:9001
2022-09-15 14:14:21 [info     ] [hathor.cli.run_node] with status                    listen=9080 with_wallet_api=False

It's now about ~11min from start to running, before without this optimization the same database loads in ~23min, so it's almost twice as fast:

2022-09-15 14:15:22 [info     ] [hathor.cli.run_node] hathor-core v0.50.2            genesis=3fdff62 hathor=0.50.2 my_peer_id=7181d232a16ba95001de22d3151b027ed31677c8cd6dc7eb88d538b250186bbf pid=5699 platform=macOS-12.5.1-arm64-arm-64bit python=3.10.4-CPython settings=/Users/jan/Projects/hathor-nodes/data-1/conf.py
2022-09-15 14:15:22 [info     ] [hathor.cli.run_node] with storage                   path=/Users/jan/Projects/hathor-nodes/data-1 storage_class=TransactionRocksDBStorage
2022-09-15 14:15:22 [info     ] [hathor.cli.run_node] with cache                     capacity=100000 interval=5
2022-09-15 14:15:22 [info     ] [hathor.cli.run_node] with indexes                   indexes_class=RocksDBIndexesManager
2022-09-15 14:15:22 [info     ] [hathor.manager] start manager                  network=mainnet
2022-09-15 14:15:22 [info     ] [hathor.p2p.manager] update whitelist
2022-09-15 14:15:22 [info     ] [hathor.manager] initialize
2022-09-15 14:15:52 [info     ] [hathor.indexes.manager] loading...  3%                 dt=~30s height=128812 latest_ts=2020-02-17 17:16:26 progress=0.03456259963520085 total=129629 tx_new=129629 tx_rate=4320.951110721801
2022-09-15 14:16:22 [info     ] [hathor.indexes.manager] loading...  6%                 dt=~30s height=246078 latest_ts=2020-03-29 15:12:38 progress=0.06600966203153291 total=247573 tx_new=117944 tx_rate=3931.45513748371
2022-09-15 14:16:52 [info     ] [hathor.indexes.manager] loading...  9%                 dt=~30s height=361289 latest_ts=2020-05-08 20:37:36 progress=0.09721729332469817 total=364619 tx_new=117046 tx_rate=3901.533054273943
2022-09-15 14:17:22 [info     ] [hathor.indexes.manager] loading... 12%                 dt=~30s height=472384 latest_ts=2020-06-16 15:40:44 progress=0.1269198148435019 total=476020 tx_new=111401 tx_rate=3713.3623285272733
2022-09-15 14:17:52 [info     ] [hathor.indexes.manager] loading... 15%                 dt=~30s height=577230 latest_ts=2020-07-23 07:56:48 progress=0.15550623547382428 total=583235 tx_new=107215 tx_rate=3573.8159512252637
2022-09-15 14:18:22 [info     ] [hathor.indexes.manager] loading... 18%                 dt=~30s height=682163 latest_ts=2020-08-28 23:04:22 progress=0.18457231819167128 total=692249 tx_new=109014 tx_rate=3633.7790340774955
2022-09-15 14:18:52 [info     ] [hathor.indexes.manager] loading... 21%                 dt=~30s height=779937 latest_ts=2020-10-02 03:10:14 progress=0.21181947108122873 total=794441 tx_new=102192 tx_rate=3406.375148420443
2022-09-15 14:19:22 [info     ] [hathor.indexes.manager] loading... 23%                 dt=~30s height=878939 latest_ts=2020-11-06 00:37:34 progress=0.2392319327502555 total=897253 tx_new=102812 tx_rate=3427.0427809674034
2022-09-15 14:19:52 [info     ] [hathor.indexes.manager] loading... 26%                 dt=~30s height=978574 latest_ts=2020-12-10 23:22:21 progress=0.26679690509969584 total=1000637 tx_new=103384 tx_rate=3446.12150201409
2022-09-15 14:20:22 [info     ] [hathor.indexes.manager] loading... 29%                 dt=~30s height=1067584 latest_ts=2021-01-11 02:27:43 progress=0.293050338922992 total=1099102 tx_new=98465 tx_rate=3282.145329833986
2022-09-15 14:20:52 [info     ] [hathor.indexes.manager] loading... 31%                 dt=~30s height=1154517 latest_ts=2021-02-10 13:08:40 progress=0.3178674527543509 total=1192180 tx_new=93078 tx_rate=3102.590186445759
2022-09-15 14:21:22 [info     ] [hathor.indexes.manager] loading... 34%                 dt=~30s height=1235854 latest_ts=2021-03-10 22:58:43 progress=0.3420430618705435 total=1282852 tx_new=90672 tx_rate=3022.398486748499
2022-09-15 14:21:52 [info     ] [hathor.indexes.manager] loading... 36%                 dt=~30s height=1316891 latest_ts=2021-04-08 08:13:57 progress=0.36648049876325034 total=1374506 tx_new=91654 tx_rate=3055.115026309253
2022-09-15 14:22:22 [info     ] [hathor.indexes.manager] loading... 39%                 dt=~30s height=1395726 latest_ts=2021-05-05 21:23:54 progress=0.3907758234310264 total=1465627 tx_new=91121 tx_rate=3037.3417556071936
2022-09-15 14:22:52 [info     ] [hathor.indexes.manager] loading... 41%                 dt=~30s height=1475213 latest_ts=2021-06-02 16:43:20 progress=0.41475439514717416 total=1555560 tx_new=89933 tx_rate=2997.7481554483034
2022-09-15 14:23:22 [info     ] [hathor.indexes.manager] loading... 43%                 dt=~30s height=1556781 latest_ts=2021-07-01 07:03:48 progress=0.43894866815782296 total=1646302 tx_new=90742 tx_rate=3024.726193939212
2022-09-15 14:23:52 [info     ] [hathor.indexes.manager] loading... 46%                 dt=~30s height=1631126 latest_ts=2021-07-27 10:17:19 progress=0.46201537531625303 total=1732815 tx_new=86513 tx_rate=2883.7599287556086
2022-09-15 14:24:22 [info     ] [hathor.indexes.manager] loading... 48%                 dt=~30s height=1703683 latest_ts=2021-08-21 23:39:57 progress=0.483640163314409 total=1813920 tx_new=81105 tx_rate=2703.495402113469
2022-09-15 14:24:52 [info     ] [hathor.indexes.manager] loading... 50%                 dt=~30s height=1768217 latest_ts=2021-09-13 13:29:02 progress=0.5053054786262414 total=1895177 tx_new=81257 tx_rate=2708.562964242062
2022-09-15 14:25:22 [info     ] [hathor.indexes.manager] loading... 52%                 dt=~30s height=1811634 latest_ts=2021-09-28 17:07:36 progress=0.5282196751042578 total=1981118 tx_new=85941 tx_rate=2864.6877743932814
2022-09-15 14:25:52 [info     ] [hathor.indexes.manager] loading... 55%                 dt=~30s height=1859932 latest_ts=2021-10-15 14:14:34 progress=0.5507784577064153 total=2065726 tx_new=84608 tx_rate=2820.239950068629
2022-09-15 14:26:22 [info     ] [hathor.indexes.manager] loading... 57%                 dt=~30s height=1906546 latest_ts=2021-10-31 21:13:03 progress=0.5734190948171165 total=2150641 tx_new=84915 tx_rate=2830.493701471993
2022-09-15 14:26:52 [info     ] [hathor.indexes.manager] loading... 59%                 dt=~30s height=1952996 latest_ts=2021-11-16 23:47:02 progress=0.5953848988296938 total=2233025 tx_new=82384 tx_rate=2746.115764878665
2022-09-15 14:27:22 [info     ] [hathor.indexes.manager] loading... 61%                 dt=~30s height=1992473 latest_ts=2021-11-30 16:59:43 progress=0.6161212854517343 total=2310798 tx_new=77773 tx_rate=2592.3556424687085
2022-09-15 14:27:52 [info     ] [hathor.indexes.manager] loading... 63%                 dt=~30s height=2027343 latest_ts=2021-12-12 19:56:50 progress=0.6358994144069801 total=2384977 tx_new=74179 tx_rate=2472.612660944308
2022-09-15 14:28:22 [info     ] [hathor.indexes.manager] loading... 65%                 dt=~30s height=2063414 latest_ts=2021-12-25 09:10:11 progress=0.6573138336519082 total=2465293 tx_new=80316 tx_rate=2677.186702269801
2022-09-15 14:28:52 [info     ] [hathor.indexes.manager] loading... 67%                 dt=~30s height=2100918 latest_ts=2022-01-07 09:49:45 progress=0.6778262535404741 total=2542226 tx_new=76933 tx_rate=2564.424957063537
2022-09-15 14:29:22 [info     ] [hathor.indexes.manager] loading... 69%                 dt=~30s height=2135233 latest_ts=2022-01-19 08:26:53 progress=0.6992124103166543 total=2622436 tx_new=80210 tx_rate=2673.648371924971
2022-09-15 14:29:52 [info     ] [hathor.indexes.manager] loading... 71%                 dt=~30s height=2176541 latest_ts=2022-02-02 17:11:54 progress=0.7196491081191407 total=2699085 tx_new=76649 tx_rate=2554.946077511131
2022-09-15 14:30:22 [info     ] [hathor.indexes.manager] loading... 73%                 dt=~30s height=2206829 latest_ts=2022-02-13 06:15:57 progress=0.739861572561089 total=2774893 tx_new=75808 tx_rate=2526.932730865622
2022-09-15 14:30:52 [info     ] [hathor.indexes.manager] loading... 76%                 dt=~30s height=2238578 latest_ts=2022-02-24 07:14:14 progress=0.7600465744154802 total=2850598 tx_new=75705 tx_rate=2523.4923590772246
2022-09-15 14:31:22 [info     ] [hathor.indexes.manager] loading... 78%                 dt=~30s height=2270016 latest_ts=2022-03-07 06:07:27 progress=0.7800657342362748 total=2925681 tx_new=75083 tx_rate=2502.7638223709537
2022-09-15 14:31:52 [info     ] [hathor.indexes.manager] loading... 79%                 dt=~30s height=2312488 latest_ts=2022-03-22 02:10:56 progress=0.7988376126532672 total=2996086 tx_new=70405 tx_rate=2346.8273090901307
2022-09-15 14:32:22 [info     ] [hathor.indexes.manager] loading... 81%                 dt=~30s height=2347349 latest_ts=2022-04-03 06:41:31 progress=0.8174444489178541 total=3065872 tx_new=69786 tx_rate=2326.1896103655417
2022-09-15 14:32:52 [info     ] [hathor.indexes.manager] loading... 83%                 dt=~30s height=2386496 latest_ts=2022-04-16 22:30:29 progress=0.8359310363767302 total=3135207 tx_new=69335 tx_rate=2311.1503380723752
2022-09-15 14:33:22 [info     ] [hathor.indexes.manager] loading... 85%                 dt=~30s height=2425736 latest_ts=2022-04-30 15:01:17 progress=0.8525541672876855 total=3197553 tx_new=62346 tx_rate=2078.188339734333
2022-09-15 14:33:52 [info     ] [hathor.indexes.manager] loading... 86%                 dt=~30s height=2463781 latest_ts=2022-05-13 21:48:46 progress=0.8695903035202505 total=3261448 tx_new=63895 tx_rate=2129.8322838973872
2022-09-15 14:34:22 [info     ] [hathor.indexes.manager] loading... 88%                 dt=~30s height=2504952 latest_ts=2022-05-28 07:24:27 progress=0.8860638566484925 total=3323233 tx_new=61785 tx_rate=2059.4753509372194
2022-09-15 14:34:52 [info     ] [hathor.indexes.manager] loading... 90%                 dt=~30s height=2547217 latest_ts=2022-06-12 01:18:48 progress=0.9018935054179953 total=3382603 tx_new=59370 tx_rate=1978.9818661523527
2022-09-15 14:35:22 [info     ] [hathor.indexes.manager] loading... 91%                 dt=~30s height=2589127 latest_ts=2022-06-26 16:35:04 progress=0.9174962545563232 total=3441122 tx_new=58519 tx_rate=1950.631240533054
2022-09-15 14:35:52 [info     ] [hathor.indexes.manager] loading... 93%                 dt=~30s height=2629890 latest_ts=2022-07-10 21:54:30 progress=0.9329563582155931 total=3499106 tx_new=57984 tx_rate=1932.7957451468992
2022-09-15 14:36:22 [info     ] [hathor.indexes.manager] loading... 94%                 dt=~30s height=2668610 latest_ts=2022-07-24 10:47:37 progress=0.9471929102797264 total=3552501 tx_new=53395 tx_rate=1779.8275339659936
2022-09-15 14:36:52 [info     ] [hathor.indexes.manager] loading... 96%                 dt=~30s height=2712842 latest_ts=2022-08-08 21:06:35 progress=0.9623943856872459 total=3609515 tx_new=57014 tx_rate=1900.4587977486162
2022-09-15 14:37:22 [info     ] [hathor.indexes.manager] loading... 97%                 dt=~30s height=2751026 latest_ts=2022-08-22 05:40:17 progress=0.9770970018586572 total=3664658 tx_new=55143 tx_rate=1838.0964648934641
2022-09-15 14:37:52 [info     ] [hathor.indexes.manager] loading... 99%                 dt=~30s height=2789211 latest_ts=2022-09-04 12:52:50 progress=0.9919025360766414 total=3720187 tx_new=55529 tx_rate=1850.9654751443586
2022-09-15 14:38:23 [info     ] [hathor.indexes.manager] loaded                         blocks=2807811 height=2796758 total_dt=~1380s tx_count=3730063 tx_rate=2701.2636644467284 txs=922252
2022-09-15 14:38:24 [info     ] [hathor.manager] ready
2022-09-15 14:38:24 [info     ] [hathor.metrics] Transaction cache hits during initialization hits=10882
2022-09-15 14:38:24 [info     ] [hathor.metrics] Transaction cache misses during initialization misses=3741080
2022-09-15 14:38:25 [info     ] [hathor.p2p.manager] listen on                      endpoint=tcp:9001
2022-09-15 14:38:25 [info     ] [hathor.cli.run_node] with status                    listen=9080 with_wallet_api=False

Acceptance Criteria

  • Have a tips index implementation that extends form the memory implementation but back-stores all intervals into the RocksDB database and simplifies loading by reading directly from those intervals instead of rebuilding it from transactions;
  • Have some kind of progress tracking for the simplified loading above;
  • Additionally port the storage's "first_timestamp, latest_timestamp, tx_count and block_count" properties into an "info" index along with memory and rocksdb implementations, this allows further optimizations where the indexes manager loading doesn't have to iterate through any transactions (previously even if no indexes needed initialization it would still need to iterate to update those properties);
  • These changes must be forward and backwards compatible: both loading an older database with a newer hathor-core version and newer database with the previous hathor-core version must work;

@jansegre jansegre self-assigned this Sep 2, 2022
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch 2 times, most recently from 7d99a96 to 2005a7e Compare September 2, 2022 23:41
@codecov
Copy link

codecov bot commented Sep 3, 2022

Codecov Report

Merging #480 (9c34541) into dev (1e28a0f) will decrease coverage by 0.00%.
The diff coverage is 89.73%.

@@            Coverage Diff             @@
##              dev     #480      +/-   ##
==========================================
- Coverage   83.44%   83.43%   -0.01%     
==========================================
  Files         174      179       +5     
  Lines       16095    16304     +209     
  Branches     2489     2500      +11     
==========================================
+ Hits        13430    13604     +174     
- Misses       2214     2243      +29     
- Partials      451      457       +6     
Impacted Files Coverage Δ
hathor/indexes/partial_rocksdb_tips_index.py 70.21% <70.21%> (ø)
hathor/indexes/memory_info_index.py 91.30% <91.30%> (ø)
hathor/indexes/manager.py 93.01% <95.83%> (-0.30%) ⬇️
hathor/indexes/memory_tips_index.py 97.64% <97.64%> (ø)
hathor/indexes/base_index.py 100.00% <100.00%> (ø)
hathor/indexes/info_index.py 100.00% <100.00%> (ø)
hathor/indexes/rocksdb_info_index.py 100.00% <100.00%> (ø)
hathor/indexes/tips_index.py 100.00% <100.00%> (+2.43%) ⬆️
hathor/transaction/storage/transaction_storage.py 94.16% <100.00%> (-0.12%) ⬇️
hathor/p2p/node_sync.py 83.61% <0.00%> (-0.49%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@msbrogli msbrogli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find tests for the new indexes. Where are they?

hathor/indexes/memory_info_index.py Show resolved Hide resolved
hathor/manager.py Outdated Show resolved Hide resolved
hathor/manager.py Outdated Show resolved Hide resolved
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch 3 times, most recently from ee53d25 to 63ea5e0 Compare September 8, 2022 17:16
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch 3 times, most recently from 4ff1456 to 88fd714 Compare September 14, 2022 14:33
@jansegre jansegre marked this pull request as ready for review September 14, 2022 14:33
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch from 88fd714 to fac3ad8 Compare September 15, 2022 13:44
@jansegre jansegre requested a review from luislhl September 15, 2022 14:40
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch from fac3ad8 to db847d1 Compare September 22, 2022 14:38
@jansegre jansegre force-pushed the feat/partial-rocksdb-tips-index branch from db847d1 to 9c34541 Compare September 23, 2022 23:55
@jansegre jansegre merged commit b29819a into dev Sep 26, 2022
@jansegre jansegre deleted the feat/partial-rocksdb-tips-index branch September 26, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants