-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(indexes): partial optimization of tips indexes using rocksdb #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d99a96
to
2005a7e
Compare
msbrogli
approved these changes
Sep 2, 2022
Codecov Report
@@ Coverage Diff @@
## dev #480 +/- ##
==========================================
- Coverage 83.44% 83.43% -0.01%
==========================================
Files 174 179 +5
Lines 16095 16304 +209
Branches 2489 2500 +11
==========================================
+ Hits 13430 13604 +174
- Misses 2214 2243 +29
- Partials 451 457 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msbrogli
requested changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find tests for the new indexes. Where are they?
ee53d25
to
63ea5e0
Compare
msbrogli
approved these changes
Sep 9, 2022
4ff1456
to
88fd714
Compare
88fd714
to
fac3ad8
Compare
luislhl
reviewed
Sep 15, 2022
luislhl
reviewed
Sep 16, 2022
luislhl
approved these changes
Sep 16, 2022
fac3ad8
to
db847d1
Compare
db847d1
to
9c34541
Compare
This was referenced Oct 11, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how it looks like on my machine, while still loading the deps and mempool indexes:
It's now about ~11min from start to running, before without this optimization the same database loads in ~23min, so it's almost twice as fast:
Acceptance Criteria