Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Remove binary and compact tx storage #505

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Nov 3, 2022

Acceptance Criteria

  1. Remove unused TransactionBinaryStorage.
  2. Remove unused TransactionCompactStorage.

They are not useful for production environments because they consume too many file system's inodes.

@msbrogli msbrogli requested a review from jansegre as a code owner November 3, 2022 19:19
@msbrogli msbrogli self-assigned this Nov 3, 2022
@msbrogli msbrogli force-pushed the feat/remove-unused-tx-storage branch from 695958c to 53b4f87 Compare November 3, 2022 19:22
@msbrogli msbrogli force-pushed the feat/remove-unused-tx-storage branch from 53b4f87 to 3631b3d Compare November 3, 2022 20:01
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #505 (3631b3d) into dev (1d0e0e7) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 3631b3d differs from pull request most recent head 51fa167. Consider uploading reports for the commit 51fa167 to get more accurate results

@@            Coverage Diff             @@
##              dev     #505      +/-   ##
==========================================
- Coverage   83.35%   83.31%   -0.05%     
==========================================
  Files         188      186       -2     
  Lines       17181    16764     -417     
  Branches     2670     2612      -58     
==========================================
- Hits        14322    13967     -355     
+ Misses       2361     2313      -48     
+ Partials      498      484      -14     
Impacted Files Coverage Δ
hathor/builder.py 73.38% <0.00%> (-0.43%) ⬇️
hathor/transaction/storage/__init__.py 75.00% <ø> (-5.00%) ⬇️
hathor/transaction/storage/transaction_storage.py 89.64% <0.00%> (-0.51%) ⬇️
hathor/indexes/base_index.py 100.00% <0.00%> (ø)
hathor/indexes/memory_info_index.py 91.66% <0.00%> (ø)
hathor/indexes/rocksdb_info_index.py 100.00% <0.00%> (ø)
hathor/p2p/node_sync.py 84.46% <0.00%> (+0.48%) ⬆️
hathor/indexes/manager.py 93.58% <0.00%> (+0.95%) ⬆️
hathor/indexes/mempool_tips_index.py 93.57% <0.00%> (+1.49%) ⬆️
hathor/indexes/partial_rocksdb_tips_index.py 70.21% <0.00%> (+2.92%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@msbrogli msbrogli force-pushed the feat/remove-unused-tx-storage branch from 3631b3d to 51fa167 Compare November 3, 2022 22:49
@msbrogli msbrogli merged commit 08b4dd9 into dev Nov 3, 2022
@msbrogli msbrogli deleted the feat/remove-unused-tx-storage branch November 3, 2022 22:51
@jansegre jansegre mentioned this pull request Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants