-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(indexes): Create a generic TxGroupIndex and uses it on AddressIndex #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msbrogli
force-pushed
the
refactor/address-index
branch
from
February 9, 2023 16:03
5ddf575
to
c03a02e
Compare
jansegre
reviewed
Feb 9, 2023
msbrogli
force-pushed
the
refactor/address-index
branch
2 times, most recently
from
February 9, 2023 18:01
3475d13
to
4172700
Compare
jansegre
approved these changes
Feb 9, 2023
Codecov Report
@@ Coverage Diff @@
## dev #524 +/- ##
==========================================
+ Coverage 82.85% 82.87% +0.02%
==========================================
Files 198 201 +3
Lines 18143 18205 +62
Branches 2564 2563 -1
==========================================
+ Hits 15032 15088 +56
- Misses 2549 2552 +3
- Partials 562 565 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
msbrogli
force-pushed
the
refactor/address-index
branch
from
February 10, 2023 18:06
4172700
to
303559d
Compare
pedroferreira1
approved these changes
Feb 12, 2023
pedroferreira1
approved these changes
Feb 12, 2023
msbrogli
force-pushed
the
refactor/address-index
branch
from
February 12, 2023 18:21
293f66f
to
ac3cef4
Compare
jansegre
approved these changes
Feb 14, 2023
msbrogli
force-pushed
the
refactor/address-index
branch
from
February 16, 2023 15:58
ac3cef4
to
7a0b9a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
TxGroupIndex
, which is an abstract class to group transactions according to a key. It will be used in future PRs.MemoryTxGroupIndex
andRocksDBTxGroupIndex
, which are abstract classes as well.AddressIndex
to use theTxGroupItem
. Specifically,MemoryAddressIndex
must useMemoryTxGroupIndex
, andRocksDBAddressIndex
must useRocksDBTxGroupIndex
.