Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(events): extract event information #535

Merged
merged 11 commits into from
Mar 2, 2023
Merged

feat(events): extract event information #535

merged 11 commits into from
Mar 2, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Feb 27, 2023

Acceptance Criteria:

  • Implement missing event attributes for EventManager extraction using classes instead of dicts

@glevco glevco self-assigned this Feb 27, 2023
@glevco glevco changed the base branch from master to dev February 28, 2023 22:03
@glevco glevco changed the title feat(event-extraction): extract event information feat(events): extract event information Feb 28, 2023
@glevco glevco marked this pull request as ready for review February 28, 2023 22:10
@glevco glevco force-pushed the feat/event-extraction branch from 2c79798 to 42536d3 Compare March 1, 2023 16:40
@glevco glevco force-pushed the feat/event-extraction branch from 42536d3 to bdfb5a7 Compare March 1, 2023 18:35
@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #535 (bdfb5a7) into dev (fc19b23) will increase coverage by 0.03%.
The diff coverage is 98.00%.

@@            Coverage Diff             @@
##              dev     #535      +/-   ##
==========================================
+ Coverage   83.15%   83.19%   +0.03%     
==========================================
  Files         209      210       +1     
  Lines       18507    18574      +67     
  Branches     2586     2587       +1     
==========================================
+ Hits        15389    15452      +63     
- Misses       2555     2557       +2     
- Partials      563      565       +2     
Impacted Files Coverage Δ
hathor/event/model/base_event.py 92.30% <92.30%> (ø)
hathor/event/__init__.py 100.00% <100.00%> (ø)
hathor/event/event_manager.py 97.01% <100.00%> (+2.07%) ⬆️
hathor/event/model/event_data.py 100.00% <100.00%> (ø)
hathor/event/resources/event.py 86.84% <100.00%> (+0.35%) ⬆️
hathor/event/storage/event_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/memory_storage.py 100.00% <100.00%> (ø)
hathor/event/storage/rocksdb_storage.py 91.22% <100.00%> (ø)
hathor/event/websocket/factory.py 92.45% <100.00%> (ø)
hathor/event/websocket/response.py 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glevco glevco merged commit 7ed6834 into dev Mar 2, 2023
@glevco glevco deleted the feat/event-extraction branch March 2, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants