feat(events): improve event mapping #543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way
EventManager
transmits events. Instead of passingHathorEvents
fromPubSub
directly to theEventStorage
and the client WebSocket, it now converts the events to a newEventType
enum that has been created.This allows for decoupling event types between internal events published via
PubSub
and what we actually want to expose as an interface to our clients, clearing up confusion related to event names and improving proximity to what was described in the original design. This also allowed bringing back events that were previously removed, as they are now separate events mapped fromPubSub
events.Acceptance Criteria:
EventType
enum replacesHathorEvents
as the type forBaseEvent
LOAD_STARTED
event has been brought back, but mapped from existingMANAGER_ON_START
event fromPubSub
.NEW_VERTEX_ACCEPTED
is now emitted instead ofNETWORK_NEW_TX_ACCEPTED
, as it's mapped from it.