Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Change should-notify-slack to disable-slack-notification and extract scripts from the workflow definition #548

Merged
merged 12 commits into from
Apr 20, 2023

Conversation

luislhl
Copy link
Collaborator

@luislhl luislhl commented Mar 31, 2023

Acceptance Criteria

  • We should extract the python CI logic from inside .github/workflows/docker.yml to an actual .py file
  • We should have unit tests for the extracted CI logic
  • Change the variable should-notify-slack to disable-slack-notification, to make the code clearer

Note: I moved the logic to extras/github/docker.py alongside its test file, but if there is a better place just let me know.

@luislhl luislhl self-assigned this Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #548 (3a33c24) into dev (3a33c24) will not change coverage.
The diff coverage is n/a.

❗ Current head 3a33c24 differs from pull request most recent head d2f2252. Consider uploading reports for the commit d2f2252 to get more accurate results

@@           Coverage Diff           @@
##              dev     #548   +/-   ##
=======================================
  Coverage   83.31%   83.31%           
=======================================
  Files         212      212           
  Lines       18729    18729           
  Branches     2596     2596           
=======================================
  Hits        15604    15604           
  Misses       2561     2561           
  Partials      564      564           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@luislhl luislhl force-pushed the ci/new-release-process branch from 15aa10d to f26b5d2 Compare March 31, 2023 14:03
@luislhl luislhl force-pushed the ci/extract-python-scripts branch from 9c66ac8 to 7a22022 Compare April 4, 2023 16:26
@luislhl luislhl force-pushed the ci/new-release-process branch from ffc4266 to e018be0 Compare April 5, 2023 14:55
@luislhl luislhl force-pushed the ci/extract-python-scripts branch 2 times, most recently from 4de2c70 to b1052cc Compare April 5, 2023 18:24
@luislhl luislhl marked this pull request as ready for review April 6, 2023 13:26
.github/workflows/docker.yml Show resolved Hide resolved
@luislhl luislhl force-pushed the ci/new-release-process branch from 4c9cf9c to 903a188 Compare April 12, 2023 19:37
@luislhl luislhl force-pushed the ci/extract-python-scripts branch from b1052cc to f9b3e0f Compare April 12, 2023 19:43
@luislhl luislhl changed the title ci: extract python scripts from inside the workflow definition chore(ci): Change should-notify-slack to disable-slack-notification and extract scripts from the workflow definition Apr 14, 2023
@luislhl luislhl force-pushed the ci/new-release-process branch from 903a188 to 0e94054 Compare April 17, 2023 12:38
@luislhl luislhl force-pushed the ci/extract-python-scripts branch from f9b3e0f to 1794e6d Compare April 17, 2023 12:42
@luislhl luislhl force-pushed the ci/new-release-process branch 4 times, most recently from c51feed to 79a4717 Compare April 19, 2023 16:34
Base automatically changed from ci/new-release-process to dev April 19, 2023 17:45
@luislhl luislhl force-pushed the ci/extract-python-scripts branch from 1794e6d to d2f2252 Compare April 19, 2023 19:31
@luislhl luislhl merged commit f7ef8a7 into dev Apr 20, 2023
@luislhl luislhl deleted the ci/extract-python-scripts branch April 20, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants