-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Change should-notify-slack to disable-slack-notification and extract scripts from the workflow definition #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #548 +/- ##
=======================================
Coverage 83.31% 83.31%
=======================================
Files 212 212
Lines 18729 18729
Branches 2596 2596
=======================================
Hits 15604 15604
Misses 2561 2561
Partials 564 564 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
15aa10d
to
f26b5d2
Compare
1 task
9c66ac8
to
7a22022
Compare
ffc4266
to
e018be0
Compare
4de2c70
to
b1052cc
Compare
jansegre
approved these changes
Apr 10, 2023
msbrogli
approved these changes
Apr 12, 2023
4c9cf9c
to
903a188
Compare
b1052cc
to
f9b3e0f
Compare
903a188
to
0e94054
Compare
f9b3e0f
to
1794e6d
Compare
c51feed
to
79a4717
Compare
…f always comparing to the BUILD_VERSION file
1794e6d
to
d2f2252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
.github/workflows/docker.yml
to an actual .py fileshould-notify-slack
todisable-slack-notification
, to make the code clearerNote: I moved the logic to
extras/github/docker.py
alongside its test file, but if there is a better place just let me know.