Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement AbstractMiner class for hathor simulator #564

Merged
merged 4 commits into from
Apr 25, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented Apr 24, 2023

Acceptance Criteria:

  • Create AbstractMiner class
  • Rename MinerSimulator to GeometricMiner and inherit from AbstractMiner

@glevco glevco self-assigned this Apr 24, 2023
@glevco glevco force-pushed the refactor/miner-simulator branch from ee5162f to bb44808 Compare April 24, 2023 14:35
@glevco glevco force-pushed the refactor/miner-simulator branch from bb44808 to f74dee0 Compare April 24, 2023 14:36
@glevco glevco marked this pull request as ready for review April 24, 2023 14:45
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #564 (ad12395) into master (4ce0568) will increase coverage by 0.00%.
The diff coverage is 98.27%.

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   83.37%   83.38%           
=======================================
  Files         214      215    +1     
  Lines       18959    18972   +13     
  Branches     2614     2614           
=======================================
+ Hits        15808    15819   +11     
- Misses       2580     2581    +1     
- Partials      571      572    +1     
Impacted Files Coverage Δ
hathor/simulator/__init__.py 100.00% <ø> (ø)
hathor/simulator/miner/abstract_miner.py 96.55% <96.55%> (ø)
hathor/simulator/miner/geometric_miner.py 100.00% <100.00%> (ø)
hathor/simulator/simulator.py 92.61% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@glevco glevco merged commit d06a842 into master Apr 25, 2023
@glevco glevco deleted the refactor/miner-simulator branch April 25, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants