Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Non-stopped simulator causing other tests to fail #578

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

msbrogli
Copy link
Member

@msbrogli msbrogli commented Apr 28, 2023

Fixes #574.

Acceptance criteria

  1. Stop simulator on tearDown().

@msbrogli msbrogli requested a review from jansegre as a code owner April 28, 2023 04:19
@msbrogli msbrogli self-assigned this Apr 28, 2023
@msbrogli msbrogli force-pushed the tests/simulator-failing-tests branch from 00c9b56 to cd96635 Compare April 28, 2023 04:52
@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #578 (cd96635) into master (17ebc11) will increase coverage by 0.04%.
The diff coverage is 95.49%.

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
+ Coverage   83.41%   83.46%   +0.04%     
==========================================
  Files         215      221       +6     
  Lines       18986    19101     +115     
  Branches     2613     2618       +5     
==========================================
+ Hits        15838    15943     +105     
- Misses       2576     2581       +5     
- Partials      572      577       +5     
Impacted Files Coverage Δ
hathor/conf/unittests.py 100.00% <ø> (ø)
hathor/transaction/transaction_metadata.py 90.69% <50.00%> (-0.97%) ⬇️
hathor/manager.py 70.84% <75.00%> (+0.11%) ⬆️
hathor/simulator/simulator.py 93.15% <80.00%> (-1.01%) ⬇️
hathor/consensus/block_consensus.py 94.34% <94.34%> (ø)
hathor/wallet/base_wallet.py 95.38% <94.89%> (-0.49%) ⬇️
hathor/consensus/transaction_consensus.py 96.11% <96.11%> (ø)
hathor/conf/settings.py 100.00% <100.00%> (ø)
hathor/consensus/__init__.py 100.00% <100.00%> (ø)
hathor/consensus/consensus.py 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@jansegre jansegre merged commit 3f4238f into master Apr 28, 2023
@jansegre jansegre deleted the tests/simulator-failing-tests branch April 28, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random tests failing after changes to the new release process
2 participants