Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events): add event simulator scenarios and tests #609

Merged
merged 2 commits into from
May 31, 2023
Merged

feat(events): add event simulator scenarios and tests #609

merged 2 commits into from
May 31, 2023

Conversation

glevco
Copy link
Contributor

@glevco glevco commented May 13, 2023 •
edited
Loading

Acceptance Criteria:

  • Implement Event Simulator scenarios (list of fixed events for clients to test their integration)
  • Implement DummyMiner
  • Implement event queue unit tests using simulation

@glevco glevco self-assigned this May 13, 2023
@glevco glevco changed the title feat: add event simulator scenarios and tests feat(events): add event simulator scenarios and tests May 13, 2023
@glevco glevco marked this pull request as ready for review May 13, 2023 03:59
@glevco glevco requested review from jansegre and msbrogli as code owners May 13, 2023 03:59
@glevco glevco mentioned this pull request May 13, 2023
Closed
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch from e0f2c80 to 26ec9b4 Compare May 13, 2023 04:25
@glevco glevco force-pushed the feat/reliable-integration/reset-queue branch from 4d10478 to 6241dae Compare May 16, 2023 23:15
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch 2 times, most recently from e476a3a to f1ae6b5 Compare May 17, 2023 02:24
@glevco glevco force-pushed the feat/reliable-integration/reset-queue branch 3 times, most recently from 79f2773 to 5dbc44e Compare May 18, 2023 20:53
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch from f1ae6b5 to 3b33e81 Compare May 18, 2023 21:00
@glevco glevco force-pushed the feat/reliable-integration/reset-queue branch from 5dbc44e to cbda38b Compare May 19, 2023 19:40
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch 2 times, most recently from 455188c to f5a2b48 Compare May 19, 2023 22:17
@codecov
Copy link

codecov bot commented May 19, 2023 •
edited
Loading

Codecov Report

Merging #609 (ebf2839) into master (e80309e) will increase coverage by 0.03%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   83.93%   83.96%   +0.03%     
==========================================
  Files         241      242       +1     
  Lines       20134    20173      +39     
  Branches     2742     2744       +2     
==========================================
+ Hits        16899    16938      +39     
+ Misses       2638     2637       -1     
- Partials      597      598       +1
Impacted Files Coverage Δ
hathor/simulator/miner/dummy_miner.py 91.66% <91.66%> (ø)
hathor/simulator/simulator.py 94.37% <100.00%> (+1.38%) ⬆️

... and 4 files with indirect coverage changes

Base automatically changed from feat/reliable-integration/reset-queue to master May 22, 2023 18:12
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch from f5a2b48 to 0cac50e Compare May 25, 2023 15:44
msbrogli
msbrogli requested changes May 25, 2023
View reviewed changes
hathor/simulator/miner/dummy_miner.py Show resolved Hide resolved
hathor/cli/events_simulator/scenario.py Outdated Show resolved Hide resolved
tests/event/test_simulation.py Show resolved Hide resolved
@glevco glevco requested a review from msbrogli May 26, 2023 22:17
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch from 46f66c7 to a6c99fd Compare May 30, 2023 19:47
@glevco glevco force-pushed the feat/reliable-integration/test-cases branch from a6c99fd to ebf2839 Compare May 31, 2023 02:55
@glevco glevco merged commit 93129a9 into master May 31, 2023
@glevco glevco deleted the feat/reliable-integration/test-cases branch May 31, 2023 04:32
@jansegre jansegre mentioned this pull request Jul 12, 2023
Merged
2 tasks
This was referenced Aug 2, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jansegre jansegre jansegre approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees

@glevco glevco

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glevco @msbrogli @jansegre